[GitHub] [camel] NiteshKoushik opened a new pull request #4238: Document Update

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] NiteshKoushik opened a new pull request #4238: Document Update

GitBox

NiteshKoushik opened a new pull request #4238:
URL: https://github.com/apache/camel/pull/4238


   Therfore to Therefore
   
   [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on a change in pull request #4238: Document Update

GitBox

oscerd commented on a change in pull request #4238:
URL: https://github.com/apache/camel/pull/4238#discussion_r489424163



##########
File path: docs/components/modules/ROOT/pages/properties-component.adoc
##########
@@ -31,7 +31,7 @@ The component supports 10 options, which are listed below.
 | *camel.component.properties.ignore-missing-location* | Whether to silently ignore if a location cannot be located, such as a properties file not found. | false | Boolean
 | *camel.component.properties.initial-properties* | Sets initial properties which will be used before any locations are resolved. The option is a java.util.Properties type. |  | String
 | *camel.component.properties.location* | A list of locations to load properties. You can use comma to separate multiple locations. This option will override any default locations and only use the locations from this option. |  | String
-| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exist. The option is a java.util.Properties type. |  | String
+| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exists. The option is a java.util.Properties type. |  | String

Review comment:
       This needs to be done in the javadoc of the componet




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] jamesnetherton commented on a change in pull request #4238: Document Update

GitBox
In reply to this post by GitBox

jamesnetherton commented on a change in pull request #4238:
URL: https://github.com/apache/camel/pull/4238#discussion_r489424672



##########
File path: docs/components/modules/ROOT/pages/properties-component.adoc
##########
@@ -368,7 +368,7 @@ The default mode is that both of them are in override mode, and they are check i
 The check stops at first found property value for the key.
 
 You can control these modes using the `systemPropertiesMode` and `environmentVariableMode`
-options on the properties component.
+options on the property's component.

Review comment:
       IMO the original wording is correct given that the name of the component is `properties`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] NiteshKoushik commented on a change in pull request #4238: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on a change in pull request #4238:
URL: https://github.com/apache/camel/pull/4238#discussion_r489429028



##########
File path: docs/components/modules/ROOT/pages/properties-component.adoc
##########
@@ -368,7 +368,7 @@ The default mode is that both of them are in override mode, and they are check i
 The check stops at first found property value for the key.
 
 You can control these modes using the `systemPropertiesMode` and `environmentVariableMode`
-options on the properties component.
+options on the property's component.

Review comment:
       sure thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] NiteshKoushik commented on pull request #4238: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #4238:
URL: https://github.com/apache/camel/pull/4238#issuecomment-693969227


   Hello @oscerd , is the below link is Javadoc file for this page, when I checked, I got this page - but feel the changes are not present in it, if this is the actual javadoc file.
   https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/PropertiesComponent.java
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on pull request #4238: Document Update

GitBox
In reply to this post by GitBox

oscerd commented on pull request #4238:
URL: https://github.com/apache/camel/pull/4238#issuecomment-694028177


   https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/component/properties/PropertiesComponent.java
   
   It should be this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] NiteshKoushik commented on pull request #4238: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #4238:
URL: https://github.com/apache/camel/pull/4238#issuecomment-695964838


   These changes are not present in javadoc file. I have reverted the changes as per the comments and also I have removed the changes which are done in the Javadoc file.
   https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/component/properties/PropertiesComponent.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd merged pull request #4238: Document Update

GitBox
In reply to this post by GitBox

oscerd merged pull request #4238:
URL: https://github.com/apache/camel/pull/4238


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] NiteshKoushik commented on pull request #4238: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #4238:
URL: https://github.com/apache/camel/pull/4238#issuecomment-695964838


   These changes are not present in javadoc file. I have reverted the changes as per the comments and also I have removed the changes which are done in the Javadoc file.
   https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/component/properties/PropertiesComponent.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd merged pull request #4238: Document Update

GitBox
In reply to this post by GitBox

oscerd merged pull request #4238:
URL: https://github.com/apache/camel/pull/4238


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]