[GitHub] [camel-k] doru1004 opened a new pull request #1816: Save dependencies into custom location

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] doru1004 opened a new pull request #1816: Save dependencies into custom location

GitBox

doru1004 opened a new pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816


   <!-- Description -->
   The inspect command produces a list of transitive dependencies that may include dependencies stored in the temporary directory of the maven project used to compute the transitive dependencies. To make these dependencies persistent we add a new option for the inspect command to allow the specification of a custom location (directory) where all transitive dependencies are to be moved after being generated. This will ensure persistence of all dependencies outside the lifetime of the kamel inspect command.
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE".
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes.
   -->
   
   **Release Note**
   ```release-note
   kind/feature
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox

astefanutti commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-732736420


   Could you please explicit the use cases you have in mind that would leverage this?
   
   I'm wondering whether the `kamel inspect integration` is the right host for this command. Naively, I would think the `kamel inspect integration --all-dependencies` should return the dependencies as listed in the IntegrationKit status, rather than executing a build based on inputs, like the catalog, that can differ from the actual inputs of the integration, hence leading to a result that's different from the actual list of dependencies for the specified integration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] doru1004 commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

doru1004 commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-737427147


   @astefanutti all dependencies prints all the jars needed to run the integration as computed by maven based on the list of top level dependencies which in turn is based on the content and type of the input integration files.
   
   In addition to that, the quarkus runner is built and needed. Although the maven computed dependencies are available after the inspect command finishes, the quarkus runner is not. To simplify the process of actually using these dependencies i.e. using them from the same location, I allow the user to specify, if desired (this is optional behavior which the user can choose to use, it's not the default behavior) a location where all the dependencies (all the jars) for the integration will be dumped.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

astefanutti commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-737734726


   @doru1004 thanks. As this performs a local build, I suggest to move the logic in the `local` subcommand. I think the later is better suited to group all the subcommands that perform actions locally. Additionally, if needed, the `kamel inspect integration --all-dependencies` can be implemented by listing the dependencies from the integration kit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti edited a comment on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

astefanutti edited a comment on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-737734726


   @doru1004 thanks. As this performs a local build, I suggest to move the logic to the `local` subcommand. I think the later is better suited to group all the subcommands that perform actions locally. Additionally, if needed, the `kamel inspect integration --all-dependencies` can be implemented by listing the dependencies from the integration kit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti edited a comment on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

astefanutti edited a comment on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-737734726


   @doru1004 thanks. As this performs a local build, I suggest to move the logic to the `local` subcommand. I think the later is better suited to group all the subcommands that perform actions locally. Additionally, if needed, the `kamel inspect integration --all-dependencies` can be implemented by listing the dependencies from the integration kit directly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] doru1004 commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

doru1004 commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-738072012


   Ah I see what you mean :)
   
   So inspect is actually a local command, there is no `kamel local inspect` at the moment. Currently the only input to this command are integration files (java, js, yaml, groovy etc).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

astefanutti commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-738083443


   Ah right. For some reasons I thought the `inspect` sub-command could also take an integration name.
   
   Out of curiosity, is the `inspect` sub-command meant to have a larger scope, or its purpose is only related to dependencies?
   
   For the `--all-dependencies` option, it is somehow running a local build. So `kamel local build` may be thing, that is being able to run a set of build tasks locally. That would complement `kamel local run` introduced by #1805 elegantly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] doru1004 commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

doru1004 commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-738092119


   I think you raise a really good point. It would be nice if inspect could take an integration name and return its dependencies or some other piece of information about it! I really like that idea. It can't do this today but perhaps it is a feature that other users may find useful?
   
   When we started I kind of only needed to look at dependencies and that's why inspect only has dependency-related flags. But it could be extended with more features like the one you suggested above.
   
   Ok so that's another good point. If we introduce a local build command it means that we need to make the build files persistent so that after you invoke `local build`, you can then do a `local run` or even a `local run --containerize` using those build files as input. We never really considered a standalone `local build` command so far because we always assumed that the respective run command will do the build under the hood. Would it be of interest to expose this step ? @nicolaferraro
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] apupier commented on pull request #1816: Add option to save transitive dependencies into custom location

GitBox
In reply to this post by GitBox

apupier commented on pull request #1816:
URL: https://github.com/apache/camel-k/pull/1816#issuecomment-759277810


   having a command to create the dependencies in a specific folder would be useful for Tooling integration. It will allow to have all dependencies part for the classpath. it will allow to have more complete completion/validation/navigation in a more reliable way than parsing the list of output and recreating a logic to download the dependencies with their transitive dependencies


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]