[GitHub] [camel-k] kaczyns opened a new pull request #1825: Sort the integration configurations before returning

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] kaczyns opened a new pull request #1825: Sort the integration configurations before returning

GitBox

kaczyns opened a new pull request #1825:
URL: https://github.com/apache/camel-k/pull/1825


   Fixes #1824
   <!-- Description -->
   The list of `spec.configurations` in the `Integration` ends up as volumes and volumeMounts in the Knative service.  The ordering of these is determined by this package: https://github.com/scylladb/go-set
   There is no ordering implied here, which is perfectly fine, except that Knative sees the order of the volumes and volume mounts as a change worthy of a new revision.  When there are many configmaps and secrets in the integration, the number of additional revisions is quite large (50-60, sometimes more) and a new pod is generated for each one.  Sorting the list before returning it ensures the ordering is consistent, and Knative will only generate a single revision.
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE".
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes.
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti merged pull request #1825: Sort the integration configurations before returning

GitBox

astefanutti merged pull request #1825:
URL: https://github.com/apache/camel-k/pull/1825


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti commented on pull request #1825: Sort the integration configurations before returning

GitBox
In reply to this post by GitBox

astefanutti commented on pull request #1825:
URL: https://github.com/apache/camel-k/pull/1825#issuecomment-732714501


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]