[GitHub] [camel] ppalaga opened a new pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] ppalaga opened a new pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox

ppalaga opened a new pull request #4061:
URL: https://github.com/apache/camel/pull/4061


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus commented on pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox

davsclaus commented on pull request #4061:
URL: https://github.com/apache/camel/pull/4061#issuecomment-667061552


   The doc files should be the name of the artifact (without the camel- prefix) when its not a component.
   
   So the old name was correct.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus edited a comment on pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox
In reply to this post by GitBox

davsclaus edited a comment on pull request #4061:
URL: https://github.com/apache/camel/pull/4061#issuecomment-667061552


   The doc files should be the name of the artifact (without the camel- prefix) when its not a component.
   
   So the old name was correct for reactive-executor-vertx
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus commented on pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox
In reply to this post by GitBox

davsclaus commented on pull request #4061:
URL: https://github.com/apache/camel/pull/4061#issuecomment-667062199


   But the thread pool factory name is wrong
   
   ❯ ls src/main/docs
   reactive-threadpoolfactory-vertx.adoc
     ~/workspace/camel/components/camel-threadpoolfactory-vertx   master ❯
   
   That should be
   
   threadpoolfactory-vertx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] ppalaga commented on pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #4061:
URL: https://github.com/apache/camel/pull/4061#issuecomment-667078671


   Oh f***, I renamed the wrong one?!?!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] ppalaga commented on pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #4061:
URL: https://github.com/apache/camel/pull/4061#issuecomment-667089330


   Thanks catching it, @davsclaus ! a1d73c8 should be OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus merged pull request #4061: CAMEL-15361 Use predictible doc page name for threadpoolfactory-vertx

GitBox
In reply to this post by GitBox

davsclaus merged pull request #4061:
URL: https://github.com/apache/camel/pull/4061


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]