Quantcast

[GitHub] camel pull request #1454: CAMEL-10809 Introduce configurator SPI for rest su...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] camel pull request #1454: CAMEL-10809 Introduce configurator SPI for rest su...

ouapdouap
GitHub user zregvart opened a pull request:

    https://github.com/apache/camel/pull/1454

    CAMEL-10809 Introduce configurator SPI for rest support in camel-core

    This removes the `SwaggerRestProducerFactory` and moves the
    responsibility of configuring rest clients to a new SPI
    (`RestEndpointConfigurer`).
   
    The rest endpoint URI has been changed to allow for syntax like:
   
        rest:<component>[:componentSpecific]
   
    Or in case of Swagger:
   
        rest:swagger:getPetById?apiDoc=petstore.json
   
    The SPI is discovered in the `META-INF/services/org/apache/camel/rest`
    properties file with the prefix `configurer.` so any other components
    wishing to configure rest endpoints via this configurer SPI should add
    `rest` file with `configurer.class` property.
   
    I would like feedback on the following issues:
     - instead of `META-INF/.../rest` use different properties file?
     - design of the RestEndpointConfigurer SPI interface (for instance: is
    it sufficient so that it can be used to plug in headers, or
    authentication callbacks for rest)
     - integration with service discovery ({{service:...}})?
     - properties missing from Swagger specification (notably host, and
    port) -- current idea is that that should be provided from
    `RestConfiguration`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/camel CAMEL-10809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1454
   
----
commit 59515f67706e588c2a86f2ba180be62c3264eb3a
Author: Zoran Regvart <[hidden email]>
Date:   2017-02-08T18:25:44Z

    CAMEL-10809 Introduce configurator SPI for rest...
   
    ... support in camel-core
   
    This removes the `SwaggerRestProducerFactory` and moves the
    responsibility of configuring rest clients to a new SPI
    (`RestEndpointConfigurer`).
   
    The rest endpoint URI has been changed to allow for syntax like:
   
        rest:<component>[:componentSpecific]
   
    Or in case of Swagger:
   
        rest:swagger:getPetById?apiDoc=petstore.json
   
    The SPI is discovered in the `META-INF/services/org/apache/camel/rest`
    properties file with the prefix `configurer.` so any other components
    wishing to configure rest endpoints via this configurer SPI should add
    `rest` file with `configurer.class` property.
   
    I would like feedback on the following issues:
     - instead of `META-INF/.../rest` use different properties file?
     - design of the RestEndpointConfigurer SPI interface (for instance: is
    it sufficient so that it can be used to plug in headers, or
    authentication callbacks for rest)
     - integration with service discovery ({{service:...}})?
     - properties missing from Swagger specification (notably host, and
    port) -- current idea is that that should be provided from
    `RestConfiguration`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] camel pull request #1454: CAMEL-10809 Introduce configurator SPI for rest su...

ouapdouap
Github user zregvart closed the pull request at:

    https://github.com/apache/camel/pull/1454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...