[GitHub] [camel-spring-boot] NiteshKoushik opened a new pull request #172: Document Update

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik opened a new pull request #172: Document Update

GitBox

NiteshKoushik opened a new pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172


   Change in keyword exist - exists and failure to failures


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-693397979


   These changes are not present in Javadoc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] jamesnetherton commented on a change in pull request #172: Document Update

GitBox
In reply to this post by GitBox

jamesnetherton commented on a change in pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#discussion_r489429058



##########
File path: docs/modules/ROOT/pages/spring-boot.adoc
##########
@@ -148,7 +148,7 @@ The component supports 157 options, which are listed below.
 | *camel.health.config.parent* | The id of the health check such as routes or registry (can use * as wildcard) |  | String
 | *camel.health.config.pool-size* | Sets the core pool size (threads to keep minimum in pool) |  | Integer
 | *camel.health.config.rejected-policy* | Sets the handler for tasks which cannot be executed by the thread pool. |  | ThreadPoolRejectedPolicy
-| *camel.health.config.time-unit* | Sets the time unit used for keep alive time |  | TimeUnit
+| *camel.health.config.time-unit* | Sets the time unit used for keeping alive time |  | TimeUnit

Review comment:
       We need to be a bit careful about rewording some of the terminology. In this context, `keep alive time` has a specific meaning. `keeping alive time` does not. So we should stick with the original wording IMO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on a change in pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on a change in pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#discussion_r489992478



##########
File path: docs/modules/ROOT/pages/spring-boot.adoc
##########
@@ -148,7 +148,7 @@ The component supports 157 options, which are listed below.
 | *camel.health.config.parent* | The id of the health check such as routes or registry (can use * as wildcard) |  | String
 | *camel.health.config.pool-size* | Sets the core pool size (threads to keep minimum in pool) |  | Integer
 | *camel.health.config.rejected-policy* | Sets the handler for tasks which cannot be executed by the thread pool. |  | ThreadPoolRejectedPolicy
-| *camel.health.config.time-unit* | Sets the time unit used for keep alive time |  | TimeUnit
+| *camel.health.config.time-unit* | Sets the time unit used for keeping alive time |  | TimeUnit

Review comment:
       got it, thanks for the information. I will revert it back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] oscerd commented on a change in pull request #172: Document Update

GitBox
In reply to this post by GitBox

oscerd commented on a change in pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#discussion_r489996578



##########
File path: docs/modules/ROOT/pages/spring-boot.adoc
##########
@@ -132,14 +132,14 @@ The component supports 157 options, which are listed below.
 | *camel.component.properties.ignore-missing-location* | Whether to silently ignore if a location cannot be located, such as a properties file not found. | false | Boolean
 | *camel.component.properties.initial-properties* | Sets initial properties which will be used before any locations are resolved. The option is a java.util.Properties type. |  | String
 | *camel.component.properties.location* | A list of locations to load properties. You can use comma to separate multiple locations. This option will override any default locations and only use the locations from this option. |  | String
-| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exist. The option is a java.util.Properties type. |  | String
+| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exists. The option is a java.util.Properties type. |  | String

Review comment:
       This needs to be done in the javadoc




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on a change in pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on a change in pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#discussion_r490003798



##########
File path: docs/modules/ROOT/pages/spring-boot.adoc
##########
@@ -132,14 +132,14 @@ The component supports 157 options, which are listed below.
 | *camel.component.properties.ignore-missing-location* | Whether to silently ignore if a location cannot be located, such as a properties file not found. | false | Boolean
 | *camel.component.properties.initial-properties* | Sets initial properties which will be used before any locations are resolved. The option is a java.util.Properties type. |  | String
 | *camel.component.properties.location* | A list of locations to load properties. You can use comma to separate multiple locations. This option will override any default locations and only use the locations from this option. |  | String
-| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exist. The option is a java.util.Properties type. |  | String
+| *camel.component.properties.override-properties* | Sets a special list of override properties that take precedence and will use first, if a property exists. The option is a java.util.Properties type. |  | String

Review comment:
       I think I have already made all the changes in the below link, this link was shared by you.
   https://github.com/apache/camel-spring-boot/edit/master/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java
   
   The changes which are made in this PR are not present in the javadoc file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-695981885


   I have already made all the changes in the below link, this link was shared by you.
   https://github.com/apache/camel-spring-boot/edit/master/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java
   
   The changes which are made in this PR are not present in the javadoc file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-695981885


   I have already made all the changes in the below link, this link was shared by you.
   https://github.com/apache/camel-spring-boot/edit/master/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java
   
   The changes which are made in this PR are not present in the javadoc file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-696564002


   Any changes required @oscerd , please let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] oscerd commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

oscerd commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-696568353


   I need to double check, the stuff is always autogenerated so modified only there will be override. Also this Pr is dirty.. maybe open a new one and add just one commit.. you'll need to have a full build of camel and then build camel-spring boot


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-696569878


   Sure.. I can do that. I will close this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-696564002






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] oscerd commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

oscerd commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-696568353


   I need to double check, the stuff is always autogenerated so modified only there will be override. Also this Pr is dirty.. maybe open a new one and add just one commit.. you'll need to have a full build of camel and then build camel-spring boot


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik closed pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik closed pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] NiteshKoushik commented on pull request #172: Document Update

GitBox
In reply to this post by GitBox

NiteshKoushik commented on pull request #172:
URL: https://github.com/apache/camel-spring-boot/pull/172#issuecomment-697134213


   Created a new PR "https://github.com/apache/camel-spring-boot/pull/177" with one commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]