[GitHub] [camel-spring-boot] PascalSchumacher opened a new pull request #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] PascalSchumacher opened a new pull request #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

GitBox
PascalSchumacher opened a new pull request #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3
 
 
   Spring 5.2 makes it possible to disable proxying of bean methods for configuration classes (with @Configuration(proxyBeanMethods=false)) to avoid the generation of cglib proxies and improve performance. For details see:
   https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/annotation/Configuration.html#proxyBeanMethods--
   
   Spring Boot (see: https://github.com/spring-projects/spring-boot/issues/9068) and other Spring projects already use this for their autoconfiguration classes.
   
   I am still running the tests locally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] PascalSchumacher commented on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

GitBox
PascalSchumacher commented on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581144291
 
 
   > Is the integration tests going well?
   
   Running a full build all unit tests and almost all integration tests passed.
   
   Three integration tests failed:
   
   >org.apache.camel.itest.springboot.CamelAwsLambdaTest  Time elapsed: 5.214 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage(CamelAwsLambdaTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-lambda-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage(CamelAwsLambdaTest.java:32)
   
   >org.apache.camel.itest.springboot.CamelAwsMqTest  Time elapsed: 4.75 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage(CamelAwsMqTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-mq-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage(CamelAwsMqTest.java:32)
   
   >org.apache.camel.itest.springboot.CamelAwsMskTest  Time elapsed: 4.48 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage(CamelAwsMskTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-msk-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage(CamelAwsMskTest.java:32)
   
   I guess these failures are not caused by this change, but by the platform I ran the test on (Windows, OpenJDK 11, OpenJ9). Most propably Windows.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] PascalSchumacher edited a comment on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

GitBox
In reply to this post by GitBox
PascalSchumacher edited a comment on issue #3: WIP: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581144291
 
 
   > Is the integration tests going well?
   
   Running a full build all unit tests and almost all integration tests passed.
   
   Three integration tests failed:
   
   >org.apache.camel.itest.springboot.CamelAwsLambdaTest  Time elapsed: 5.214 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage(CamelAwsLambdaTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-lambda-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsLambdaTest.createSpringBootPackage(CamelAwsLambdaTest.java:32)
   
   >org.apache.camel.itest.springboot.CamelAwsMqTest  Time elapsed: 4.75 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage(CamelAwsMqTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-mq-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsMqTest.createSpringBootPackage(CamelAwsMqTest.java:32)
   
   >org.apache.camel.itest.springboot.CamelAwsMskTest  Time elapsed: 4.48 sec  <<< ERROR!
   java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage() throws java.lang.Exception
    at org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage(CamelAwsMskTest.java:32)
   Caused by: java.io.FileNotFoundException: C:\Users\User\camel-spring-boot\camel-itest-spring-boot\..\components-starter\camel-aws-msk-starter\pom.xml (Das System kann die angegebene Datei nicht finden)
    at org.apache.camel.itest.springboot.CamelAwsMskTest.createSpringBootPackage(CamelAwsMskTest.java:32)
   
   I guess these failures are not caused by this change, but by the platform I ran the test on (Windows, OpenJDK 11, OpenJ9). Most propably Windows.
   
   Edit:
   If I run just one of the three failed tests mentioned above it passes.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] PascalSchumacher commented on issue #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

GitBox
In reply to this post by GitBox
PascalSchumacher commented on issue #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3#issuecomment-581153165
 
 
   Examples also still work with this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-spring-boot] asfgit merged pull request #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes

GitBox
In reply to this post by GitBox
asfgit merged pull request #3: CAMEL-14471: camel-spring-boot: Disable proxying of bean methods for auto-configuration classes
URL: https://github.com/apache/camel-spring-boot/pull/3
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services