[GitHub] [camel] swapy opened a new pull request #5309: Add proper endChoice() and end() blocks

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] swapy opened a new pull request #5309: Add proper endChoice() and end() blocks

GitBox

swapy opened a new pull request #5309:
URL: https://github.com/apache/camel/pull/5309


   Need to add proper endChoice() and end() blocks to show correct way to work with choices(as a best practice).
   
   Also not sure about following:
   1. do we need to add endChoice() after otherwise()?
   2. do we need to make any changes in xml based configuration or it ends by default?(I suppose it works by default)
   3. Do we also need to document meaning of endChoice() and end()?
   
   <!-- Uncomment and fill this section if your PR is not trivial
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md
   -->
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] swapy commented on pull request #5309: Add proper endChoice() and end() blocks

GitBox

swapy commented on pull request #5309:
URL: https://github.com/apache/camel/pull/5309#issuecomment-815121544


   @oscerd Somehow I am not able to fork this repository.
   
   It always creates a fork of 3.4.x
   ![image](https://user-images.githubusercontent.com/1929023/113914321-0c11a300-97fb-11eb-9030-0c6bbb10d94c.png)
   
   
   I am not sure what would be the correct way.
   
   if I continue with the fork, it adds too many additional commits in PR


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] swapy edited a comment on pull request #5309: Add proper endChoice() and end() blocks

GitBox
In reply to this post by GitBox

swapy edited a comment on pull request #5309:
URL: https://github.com/apache/camel/pull/5309#issuecomment-815121544


   @oscerd Somehow I am not able to fork this repository.
   
   It always creates a fork of 3.4.x
   ![image](https://user-images.githubusercontent.com/1929023/113914321-0c11a300-97fb-11eb-9030-0c6bbb10d94c.png)
   
   
   I am not sure what would be the correct way.
   
   if I continue with the fork, it adds too many additional commits in PR.
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on pull request #5309: Add proper endChoice() and end() blocks

GitBox
In reply to this post by GitBox

oscerd commented on pull request #5309:
URL: https://github.com/apache/camel/pull/5309#issuecomment-815122384


   You are looking at the 3.4.x docs. Switch to latest there is a drop-down menu if you are navigating the website


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] swapy closed pull request #5309: Add proper endChoice() and end() blocks

GitBox
In reply to this post by GitBox

swapy closed pull request #5309:
URL: https://github.com/apache/camel/pull/5309


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] swapy commented on pull request #5309: Add proper endChoice() and end() blocks

GitBox
In reply to this post by GitBox

swapy commented on pull request #5309:
URL: https://github.com/apache/camel/pull/5309#issuecomment-815125547


   should close this PR in favour of #5311


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]