[GitHub] [camel] tapiiron opened a new pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] tapiiron opened a new pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox

tapiiron opened a new pull request #4643:
URL: https://github.com/apache/camel/pull/4643


   Addresses wish CAMEL-15872


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on a change in pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox

oscerd commented on a change in pull request #4643:
URL: https://github.com/apache/camel/pull/4643#discussion_r527664916



##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -187,6 +193,18 @@ public String getQuery() {
         return query;
     }
 
+    /**
+     * The JWT Authorization type. Default is Bearer.
+     * @param jwtAuthorizationType

Review comment:
       Please remove param annotation.

##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -110,8 +112,12 @@ private CloseableHttpClient createHttpClient() {
             httpClientBuilder.setProxy(new HttpHost(hostname, port));
         }
         if (accessToken != null) {
+            String authType = "Bearer";
+            if(this.jwtAuthorizationType != null) {

Review comment:
       If you run a full build, this should be formatted to respect the camel code style standards.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] tapiiron commented on a change in pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox
In reply to this post by GitBox

tapiiron commented on a change in pull request #4643:
URL: https://github.com/apache/camel/pull/4643#discussion_r527667308



##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -187,6 +193,18 @@ public String getQuery() {
         return query;
     }
 
+    /**
+     * The JWT Authorization type. Default is Bearer.
+     * @param jwtAuthorizationType

Review comment:
       Removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] tapiiron commented on a change in pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox
In reply to this post by GitBox

tapiiron commented on a change in pull request #4643:
URL: https://github.com/apache/camel/pull/4643#discussion_r527667920



##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -110,8 +112,12 @@ private CloseableHttpClient createHttpClient() {
             httpClientBuilder.setProxy(new HttpHost(hostname, port));
         }
         if (accessToken != null) {
+            String authType = "Bearer";
+            if(this.jwtAuthorizationType != null) {

Review comment:
       That missed my eye but should be fixed now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus commented on a change in pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox
In reply to this post by GitBox

davsclaus commented on a change in pull request #4643:
URL: https://github.com/apache/camel/pull/4643#discussion_r528117335



##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -65,6 +65,8 @@
     @UriParam(label = "security", secret = true)
     private String password;
     @UriParam
+    private String jwtAuthorizationType;

Review comment:
       Can you set label = "security", and default = "Bearer" in the uri param annotation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] tapiiron commented on a change in pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox
In reply to this post by GitBox

tapiiron commented on a change in pull request #4643:
URL: https://github.com/apache/camel/pull/4643#discussion_r528489207



##########
File path: components/camel-graphql/src/main/java/org/apache/camel/component/graphql/GraphqlEndpoint.java
##########
@@ -65,6 +65,8 @@
     @UriParam(label = "security", secret = true)
     private String password;
     @UriParam
+    private String jwtAuthorizationType;

Review comment:
       Sure thing, added those now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] davsclaus merged pull request #4643: [CAMEL-15872] JWT Authorization Type Configuration Option to GraphQL Component

GitBox
In reply to this post by GitBox

davsclaus merged pull request #4643:
URL: https://github.com/apache/camel/pull/4643


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]