[GitHub] [camel-website] ppalaga opened a new pull request #457: Add FontAwesome

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga opened a new pull request #457: Add FontAwesome

GitBox

ppalaga opened a new pull request #457:
URL: https://github.com/apache/camel-website/pull/457


   Motivated by https://github.com/apache/camel-quarkus/issues/1410 , based on https://gitlab.com/antora/antora-ui-default/-/merge_requests/121/diffs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #457: Add FontAwesome

GitBox

zregvart commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-673717564


   I suspect that this will add significant weight to the pages, and I'm not sure if we're going to use more than several FontAwesome icons. Perhaps it would be worthwhile to investigate a [customized version](https://github.com/FortAwesome/Font-Awesome/wiki/Customize-Font-Awesome#the-easy-way) including only icons that we do use. As an alternative we could use the unicode lock symbol: `🔒` (🔒).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #457: Add FontAwesome

GitBox
In reply to this post by GitBox

zregvart commented on a change in pull request #457:
URL: https://github.com/apache/camel-website/pull/457#discussion_r470257154



##########
File path: antora-ui-camel/gulp.d/tasks/build.js
##########
@@ -46,7 +46,18 @@ module.exports = (src, dest, preview) => () => {
           const basename = ospath.basename(abspath)
           const destpath = ospath.join(dest, 'font', basename)
           if (!fs.pathExistsSync(destpath)) fs.copySync(abspath, destpath)
-          return path.join('..', 'font', basename)
+          return path.join('..', 'font', basename) + asset.search + asset.hash

Review comment:
       Not sure about this change, doesn't seem to be related to adding Font Awesome.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Add FontAwesome

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-673925366


   Thanks for the feedback, @zregvart ! I am a frontend noob happy to follow any advice :) OK, let me try to extract only the relevant CSS and try the unicode glyph.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-674810278


   c0e2e6b adopts the proposal to emulate `fa-lock` with 🔒 unicode character


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga edited a comment on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga edited a comment on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-674810278


   c0e2e6b adopts the proposal of @zregvart to emulate `fa-lock` with 🔒 unicode character


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-674811426


   ups, there are changes in c0e2e6b that should not be there, let me filter them out


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-674812648


   f25b8f5 is what it should be


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-675147278


   The lock sign can be seen e.g. here https://deploy-preview-457--camel.netlify.app/camel-quarkus/latest/extensions/microprofile-metrics.html#_additional_camel_quarkus_configuration 
   Would please somebody review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

zregvart commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-675148805


   @ppalaga this can be done without adding any new CSS, i.e. by adding the icon as [unicode character](https://docs.antora.org/antora/2.3/asciidoc/special-characters-and-symbols/) to the adoc file. I think that way we would not couple what icons can be used in docs to the state of CSS on the website.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-675338433


   > @ppalaga this can be done without adding any new CSS, i.e. by adding the icon as [unicode character]
   
   In our situation, it is rather hard to do, because we get `icon:lock[title=Fixed at build time]` hard coded from Quarkus tooling https://github.com/quarkusio/quarkus/blob/master/core/processor/src/main/java/io/quarkus/annotation/processor/Constants.java#L78 and I'd prefer not to rewrite it.
   
   I thought, because font awesome is commonly used in both AsciiDoc [1][2] and Antora (it is a part of the default UI now [3]), having some level of CSS support on our website would be quite natural too.
   
   [1] https://asciidoctor.org/docs/user-manual/#admonition-icons
   [2] https://asciidoctor.org/docs/user-manual/#inline-icons
   [3] https://gitlab.com/antora/antora-ui-default/-/merge_requests/121


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

zregvart commented on pull request #457:
URL: https://github.com/apache/camel-website/pull/457#issuecomment-675696724


   > >
   >
   > In our situation, it is rather hard to do, because we get `icon:lock[title=Fixed at build time]` hard coded from Quarkus tooling [https://github.com/quarkusio/quarkus/blob/master/core/processor/src/main/java/io/quarkus/annotation/processor/Constants.java#L78](https://github.com/quarkusio/quarkus/blob/master/core/processor/src/main/java/io/quarkus/annotation/processor/Constants.java?rgh-link-date=2020-08-18T08%3A27%3A36Z#L78) and I'd prefer not to rewrite it.
   
   Right, I thought we were in full control of the docs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart merged pull request #457: Emulate the parts of FontAwesome that we use

GitBox
In reply to this post by GitBox

zregvart merged pull request #457:
URL: https://github.com/apache/camel-website/pull/457


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]