[GitHub] [camel-website] zregvart opened a new pull request #455: fix: broken links and HTML validation

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart opened a new pull request #455: fix: broken links and HTML validation

GitBox

zregvart opened a new pull request #455:
URL: https://github.com/apache/camel-website/pull/455


   This fixes broken link to component reference and outstanding HTML
   validation issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #455: fix: broken links and HTML validation

GitBox

zregvart commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-672272506


   @aashnajena and @AemieJ can you have a look at this and see if I missed something?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on a change in pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

AemieJ commented on a change in pull request #455:
URL: https://github.com/apache/camel-website/pull/455#discussion_r469018925



##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -114,6 +114,12 @@ section.frontpage.columns.blog-posts {
   background-color: var(--color-smoke-50);
 }
 
+section.frontpage.blog-posts ul {
+  display: flex;

Review comment:
       ```suggestion
     display: flex;
     flex-wrap: wrap;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-672623108


   In addition to it, the text isn't aligned with the icon within projects section for the frontpage in the mobile view.
   Add the media screen code in addition to the previous code for frontpage content.
   
   ```
   section.frontpage.columns.functionalities h2,
   section.frontpage.projects .project .content h2,
   section.frontpage.projects .project .content p {
     text-align: left;
     text-transform: none;
    @media screen and (max-width: 626px) {
         text-align: center;
     }
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

aashnajena commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-672703372


   The second problem I see is that blog-posts are not getting aligned as a column at <1023px. To amend this, line 287 of frontpage.css reads:
   
   ```
   section.frontpage.columns.blog-posts {
       flex-direction: column;
     }
   ```
   
   We must change it to:
   
   ```
   section.frontpage.columns.blog-posts ul {
       flex-direction: column;
     }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on a change in pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

aashnajena commented on a change in pull request #455:
URL: https://github.com/apache/camel-website/pull/455#discussion_r469077419



##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -114,6 +114,12 @@ section.frontpage.columns.blog-posts {
   background-color: var(--color-smoke-50);
 }
 
+section.frontpage.blog-posts ul {
+  display: flex;

Review comment:
       This change seems problematic.. This is how it looks for me:
   
   ![Screenshot 2020-08-12 at 1 27 16 PM](https://user-images.githubusercontent.com/32356795/89990275-bdc5f780-dc9f-11ea-897a-2eeab6a2326b.png)
   
   I've suggested another change to make sure the **flex-direction** of the **blog-posts** section becomes **'column'** for <1023px.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

zregvart commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-672741216


   Thanks! I’ll make the changes a bit later today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

zregvart commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-673042399


   I tried to include all suggestions. I did found that using padding rather than margin for the list of blog posts works better with sizing. I also found `border-radius` directive on a element without a border (I think we have several of those, we're going to need to clean that up a bit). Hopefully this is better now. Can you have another look @aashnajena and @AemieJ. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on a change in pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

aashnajena commented on a change in pull request #455:
URL: https://github.com/apache/camel-website/pull/455#discussion_r469483644



##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -97,7 +97,6 @@ div.frontpage.news {
   text-align: center;
   margin-left: 3rem;
   background-color: var(--color-smoke-50);
-  border-radius: 1rem 1rem 0 0;

Review comment:
       This border radius is for for the "what's new" title div on desktop view. I think we can keep this..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-673212257


   [This](https://github.com/apache/camel-website/pull/455#issuecomment-672623108) needs to be applied yet as the content of the project and button are left-aligned within the mobile screen.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on a change in pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

aashnajena commented on a change in pull request #455:
URL: https://github.com/apache/camel-website/pull/455#discussion_r469858938



##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -353,13 +366,13 @@ section.frontpage.projects .project img {
     padding: 0;
   }
 
-  section.frontpage.projects .project h2,
+  section.frontpage.projects .project .content h2,
   section.frontpage.projects .project .icon,
   section.frontpage.columns.functionalities .box .content h2,
   section.frontpage.columns.functionalities .box .content,
   section.frontpage.columns.functionalities .box .icon,
   section.frontpage.columns.functionalities p,
-  section.frontpage.projects p {
+  section.frontpage.projects .content p {

Review comment:
       @AemieJ instead of adding a media-code snippet, this line should to be scoped to `section.frontpage.projects .project .content p`. It's getting overwritten by the rule on line 197. Sorry for missing it out before.

##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -353,13 +366,13 @@ section.frontpage.projects .project img {
     padding: 0;
   }
 
-  section.frontpage.projects .project h2,
+  section.frontpage.projects .project .content h2,
   section.frontpage.projects .project .icon,
   section.frontpage.columns.functionalities .box .content h2,
   section.frontpage.columns.functionalities .box .content,
   section.frontpage.columns.functionalities .box .icon,
   section.frontpage.columns.functionalities p,
-  section.frontpage.projects p {
+  section.frontpage.projects .content p {

Review comment:
       ```suggestion
     section.frontpage.projects .project .content p {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on a change in pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

ppalaga commented on a change in pull request #455:
URL: https://github.com/apache/camel-website/pull/455#discussion_r470065884



##########
File path: content/_index.md
##########
@@ -56,7 +56,7 @@ Apache Camel is standalone, and can be embedded as a library within Spring Boot,
 ## Packed with Components
 Packed with several hundred components that are used to access databases, message queues, APIs or basically anything under the sun. Helping you integrate with everything.
 
-<p><a class="button-dark" href="/components/latest">Go to Component Reference</a></p>
+<p><a class="button-dark" href="/components/latest/">Go to Component Reference</a></p>

Review comment:
       I dared to take the link fixes to https://github.com/apache/camel-website/pull/456 so that we can publish Quarkus 1.0.0 announcement.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

zregvart commented on pull request #455:
URL: https://github.com/apache/camel-website/pull/455#issuecomment-673713885


   We need to get this merged to successfully build the website. Thanks for the review and suggestions @aashnajena and @AemieJ. If there are more issues with this please create followup PRs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart merged pull request #455: fix: broken links and HTML validation

GitBox
In reply to this post by GitBox

zregvart merged pull request #455:
URL: https://github.com/apache/camel-website/pull/455


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]