[GitHub] [camel-website] zregvart opened a new pull request #459: CAMEL-15337: Add TOC to static content

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart opened a new pull request #459: CAMEL-15337: Add TOC to static content

GitBox

zregvart opened a new pull request #459:
URL: https://github.com/apache/camel-website/pull/459


   Based on work by @AemieJ in #446 this simplifies the implementation by
   relying on the implementation already provided by Antora.
   
   The main issue with reusing the Antora implementation was that the
   markup of rendered Asciidoc contains `<div class="sect?">` elements
   around the chapters. Hugo rendered, static, content does not have this,
   so the logic for the _on this page_ functionality needed to be adjusted
   slightly because of this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #459: CAMEL-15337: Add TOC to static content

GitBox

zregvart commented on pull request #459:
URL: https://github.com/apache/camel-website/pull/459#issuecomment-673752172


   @AemieJ can you have a look at this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on pull request #459: CAMEL-15337: Add TOC to static content

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #459:
URL: https://github.com/apache/camel-website/pull/459#issuecomment-673849932


   @zregvart I didn't see that the Hugo missed that section. This is a much easier implementation and it works perfectly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart merged pull request #459: CAMEL-15337: Add TOC to static content

GitBox
In reply to this post by GitBox

zregvart merged pull request #459:
URL: https://github.com/apache/camel-website/pull/459


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]