[GitHub] lburgazzoli commented on a change in pull request #257: chore: add all sorts of linters and pre-commit hook

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] lburgazzoli commented on a change in pull request #257: chore: add all sorts of linters and pre-commit hook

GitBox
lburgazzoli commented on a change in pull request #257: chore: add all sorts of linters and pre-commit hook
URL: https://github.com/apache/camel-k/pull/257#discussion_r239100228
 
 

 ##########
 File path: pkg/client/cmd/root.go
 ##########
 @@ -57,21 +58,27 @@ func NewKamelCommand(ctx context.Context) (*cobra.Command, error) {
  cmd.PersistentFlags().StringVarP(&options.Namespace, "namespace", "n", "", "Namespace to use for all operations")
 
  // Parse the flags before setting the defaults
- cmd.ParseFlags(os.Args)
+ err := cmd.ParseFlags(os.Args)
 
 Review comment:
   i guess we should ignore the error for the moment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services