[GitHub] nicolaferraro commented on a change in pull request #68: Support for integration configuration

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] nicolaferraro commented on a change in pull request #68: Support for integration configuration

GitBox
nicolaferraro commented on a change in pull request #68: Support for integration configuration
URL: https://github.com/apache/camel-k/pull/68#discussion_r217622133
 
 

 ##########
 File path: pkg/util/maven/types.go
 ##########
 @@ -25,7 +25,7 @@ type ProjectDefinition struct {
  Project     Project
  JavaSources map[string]string
  Resources   map[string]string
- Env         map[string]string
+ Env         map[string]string // TODO: should we deprecate it ? env are set on deployment
 
 Review comment:
   I'm thinking to a "merge" function, where the configuration at context level is used as base for the configuration at integration level. We can do it when creating the integration, so you're right, this can be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services