Quantcast

Odd info logs about startup w/ autoStartup=false

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Odd info logs about startup w/ autoStartup=false

Jason Dillon
Any reason why these are at INFO level in DefaultCamelContext?

<snip>
if (doNotStartRoutesOnFirstStart) {
    log.info("Cannot start routes as CamelContext has been configured with autoStartup=false");
}
</snip>

<snip>
if (addingRoute && !autoStartup) {
    log.info("Cannot start route " + routeService.getId() + " as its configured with autoStartup=false");
    continue;
}
</snip>

The language sounds like something strange/bad happened, but configuring autoStartup=false isn't strange or bad.  I don't get why this detail is logged at INFO.

Its not really a big deal, I was just surprised to see it in my logs after I added a route w/ this set so that I could thread the start of the route in the background.

--jason
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Odd info logs about startup w/ autoStartup=false

Claus Ibsen-2
Hi

Yeah the wording could be improved. Any recommendation?


On Thu, Dec 1, 2011 at 12:28 AM, Jason Dillon <[hidden email]> wrote:

> Any reason why these are at INFO level in DefaultCamelContext?
>
> <snip>
> if (doNotStartRoutesOnFirstStart) {
>    log.info("Cannot start routes as CamelContext has been configured with autoStartup=false");
> }
> </snip>
>
> <snip>
> if (addingRoute && !autoStartup) {
>    log.info("Cannot start route " + routeService.getId() + " as its configured with autoStartup=false");
>    continue;
> }
> </snip>
>
> The language sounds like something strange/bad happened, but configuring autoStartup=false isn't strange or bad.  I don't get why this detail is logged at INFO.
>
> Its not really a big deal, I was just surprised to see it in my logs after I added a route w/ this set so that I could thread the start of the route in the background.
>
> --jason



--
Claus Ibsen
-----------------
FuseSource
Email: [hidden email]
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Odd info logs about startup w/ autoStartup=false

Claus Ibsen-2
Hi

I created a ticket to track this
https://issues.apache.org/jira/browse/CAMEL-4744

On Thu, Dec 1, 2011 at 10:33 AM, Claus Ibsen <[hidden email]> wrote:

> Hi
>
> Yeah the wording could be improved. Any recommendation?
>
>
> On Thu, Dec 1, 2011 at 12:28 AM, Jason Dillon <[hidden email]> wrote:
>> Any reason why these are at INFO level in DefaultCamelContext?
>>
>> <snip>
>> if (doNotStartRoutesOnFirstStart) {
>>    log.info("Cannot start routes as CamelContext has been configured with autoStartup=false");
>> }
>> </snip>
>>
>> <snip>
>> if (addingRoute && !autoStartup) {
>>    log.info("Cannot start route " + routeService.getId() + " as its configured with autoStartup=false");
>>    continue;
>> }
>> </snip>
>>
>> The language sounds like something strange/bad happened, but configuring autoStartup=false isn't strange or bad.  I don't get why this detail is logged at INFO.
>>
>> Its not really a big deal, I was just surprised to see it in my logs after I added a route w/ this set so that I could thread the start of the route in the background.
>>
>> --jason
>
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: [hidden email]
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/



--
Claus Ibsen
-----------------
FuseSource
Email: [hidden email]
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Odd info logs about startup w/ autoStartup=false

Jason Dillon
In reply to this post by Claus Ibsen-2
On Dec 1, 2011, at 1:33 AM, Claus Ibsen wrote:
> Yeah the wording could be improved. Any recommendation?

Is it important to log this information as INFO level?  I don't see any of the other attributes of a route logged in this fashion.  Is it common that folks set autoStartup(false) and then forget to start manually and wonder why a route is not started?

Wording wise, I think something like this may be better:

"Route %s not started due to configured with autoStartup=false"

or:

"Skipping start of route %s; configured with autoStartup=false"

--jason

Loading...