[jira] Created: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
Spring DSL - Delay use attribute for constant delay
---------------------------------------------------

                 Key: CAMEL-1264
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-spring
    Affects Versions: 1.5.0
            Reporter: Claus Ibsen
             Fix For: 2.0.0


The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.

{code}
    <route>
      <from uri="seda:b"/>
      <delay>
        <expression/>
        <delayTime>3000</delayTime>
      </delay>
      <to uri="mock:result"/>
    </route>
{code}

We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.

{code}
<delay delayTime="3000"/>
<to uri="mock:result"/>
{code}




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48743#action_48743 ]

Claus Ibsen commented on CAMEL-1264:
------------------------------------

Note there is a master JIRA ticket for Spring DSL issues that Jonathan has assigned.

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-1264:
-------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: CAMEL-745

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48756#action_48756 ]

Claus Ibsen commented on CAMEL-1264:
------------------------------------

Got it to this now
{code}
            <delay delayTime="3000">
                <simple>header.JMSTimestamp</simple>
            </delay>
{code}

But curse JAXB as its damm hard to get it being optional expression. Only solution is probably to hack the XSD or create two delay types
{code}
<constantDelay delayTime="3000"/>
{code}

Or as:
{code}
<expressionDelay>
                <simple>header.JMSTimestamp</simple>
            </expressionDelay>
{code}


> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48757#action_48757 ]

Claus Ibsen commented on CAMEL-1264:
------------------------------------

The hacking is:

FROM
{code}
  <xs:complexType name="optionalExpressionNode" abstract="true">
    <xs:complexContent>
      <xs:extension base="tns:processorType">
        <xs:sequence>
          <xs:choice maxOccurs="1" minOccurs="1">
{code}

TO
{code}
  <xs:complexType name="optionalExpressionNode" abstract="true">
    <xs:complexContent>
      <xs:extension base="tns:processorType">
        <xs:sequence>
          <xs:choice maxOccurs="1" minOccurs="0">
{code}

Its this that JAXB generates as mandatory
          <xs:choice maxOccurs="1" minOccurs="1">

That should be optional for the optionalExpressionNode

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48760#action_48760 ]

Claus Ibsen commented on CAMEL-1264:
------------------------------------

davsclaus:(svn)camel[trunk:734935]/$ svn commit --message "CAMEL-1264: Delayer in Spring DSL now uses an attribute for delayTime."
Sending        camel-core/src/main/java/org/apache/camel/model/DelayerType.java
Sending        components/camel-spring/src/test/resources/org/apache/camel/spring/processor/delayer.xml
Transmitting file data ..
Committed revision 734938.

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-1264:
----------------------------------

    Assignee: Claus Ibsen

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-1264) Spring DSL - Delay use attribute for constant delay

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-1264.
--------------------------------

    Resolution: Fixed

Updated wiki.

> Spring DSL - Delay use attribute for constant delay
> ---------------------------------------------------
>
>                 Key: CAMEL-1264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1264
>             Project: Apache Camel
>          Issue Type: Sub-task
>          Components: camel-spring
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The Spring DSL for delay is not good for constant delay, to eg use 3000 millis then you need to add a sub empty expression that is very confusing.
> {code}
>     <route>
>       <from uri="seda:b"/>
>       <delay>
>         <expression/>
>         <delayTime>3000</delayTime>
>       </delay>
>       <to uri="mock:result"/>
>     </route>
> {code}
> We should use an attrbute for constant delay instead. So delayTime is an attribute instead on delay.
> {code}
> <delay delayTime="3000"/>
> <to uri="mock:result"/>
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.