Camel › Camel - Commits

svn commit: r1205412 - /camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

Classic

List

Threaded

4 messages Options

ningjiang

svn commit: r1205412 - /camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

Author: ningjiang
Date: Wed Nov 23 14:19:36 2011
New Revision: 1205412

URL: http://svn.apache.org/viewvc?rev=1205412&view=rev
Log:
CAMEL-3774 write a better dummy html with thanks to Babak

Modified:
camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

Modified: camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java
URL: http://svn.apache.org/viewvc/camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java?rev=1205412&r1=1205411&r2=1205412&view=diff
==============================================================================
--- camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java (original)
+++ camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java Wed Nov 23 14:19:36 2011
@@ -243,7 +243,8 @@ public class HtmlToPdfMojo extends Abstr
private void storeDummyFile() throws FileNotFoundException {
PrintWriter out = new PrintWriter(new BufferedOutputStream(new FileOutputStream(getHTMLFileName())));
out.println("<html>");
- out.println("<body>Download of " + page + " failed</body>");
+ out.println("<body>Generation of the offline PDF version of the manual failed, however you could try <a href=\"http://camel.apache.org/book-in-one-page.html\">the online HTML version</a>.</body>");
+ out.println("</html>");
out.close();
getLog().info("Stored dummy file: " + getHTMLFileName() + " since download of " + page + " failed.");
}

Babak Vahdat

Re: svn commit: r1205412 - /camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

This post has NOT been accepted by the mailing list yet.

Hi Willem,

thanks for applying that change which indeed defuses the problem, however I'm afraid that '.' at the end of the sentence:

the online HTML version.

should be before the ending "a" tag and *not* after it. IMHO that html is still invalid.

Babak

Babak Vahdat

Re: svn commit: r1205412 - /camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

This post has NOT been accepted by the mailing list yet.

That said I'm not really 100% sure about it as testing such a content through http://validator.w3.org/ it seems as if the w3c validator doesn't really care about it.

Babak

Willem.Jiang

Re: svn commit: r1205412 - /camel/trunk/tooling/maven/maven-html-to-pdf/src/main/java/org/apache/camel/maven/HtmlToPdfMojo.java

This post has NOT been accepted by the mailing list yet.

I did the change to make sure the "." is not part of the link.

bvahdat wrote

That said I'm not really 100% sure about it as testing such a content through http://validator.w3.org/ it seems as if the w3c validator doesn't really care about it.

Babak