Build fails since AS2 component was added

classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Build fails since AS2 component was added

Pascal Schumacher
Hello everybody,

since the camel-as2 component was added, all master builds on
builds.apache.org fail with:

[INFO] BUILD FAILURE
...
[ERROR] Failed to execute goal org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis (generate-test-component-classes) on project camel-as2:
Error generating source for org.apache.camel.component.as2.api.AS2ClientManager:
No public non-static methods found, make sure Javadoc is available as project test dependency -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis (generate-test-component-classes) on project camel-as2:
Error generating source for org.apache.camel.component.as2.api.AS2ClientManager: No public non-static methods found, make sure Javadoc is available as project test dependency

See e.g.:
https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console

I guess something was forgotten when adding the component? It would be
great if somebody could fix this.

Thanks,

Pascal

Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Andrea Cosentino-2
I'll have a look

--
Andrea Cosentino 
----------------------------------
Apache Camel PMC Member
Apache Karaf Committer
Apache Servicemix PMC Member
Email: [hidden email]
Twitter: @oscerd2
Github: oscerd






On Sunday, April 29, 2018, 2:42:41 PM GMT+2, Pascal Schumacher <[hidden email]> wrote:





Hello everybody,

since the camel-as2 component was added, all master builds on
builds.apache.org fail with:

[INFO] BUILD FAILURE
...
[ERROR] Failed to execute goal org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis (generate-test-component-classes) on project camel-as2:
Error generating source for org.apache.camel.component.as2.api.AS2ClientManager:
No public non-static methods found, make sure Javadoc is available as project test dependency -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis (generate-test-component-classes) on project camel-as2:
Error generating source for org.apache.camel.component.as2.api.AS2ClientManager: No public non-static methods found, make sure Javadoc is available as project test dependency

See e.g.:
https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console

I guess something was forgotten when adding the component? It would be
great if somebody could fix this.

Thanks,

Pascal

Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

jbonofre
I will too.

Regards
JB

Le 2 mai 2018 à 08:11, à 08:11, Andrea Cosentino <[hidden email]> a écrit:

>I'll have a look
>
>--
>Andrea Cosentino 
>----------------------------------
>Apache Camel PMC Member
>Apache Karaf Committer
>Apache Servicemix PMC Member
>Email: [hidden email]
>Twitter: @oscerd2
>Github: oscerd
>
>
>
>
>
>
>On Sunday, April 29, 2018, 2:42:41 PM GMT+2, Pascal Schumacher
><[hidden email]> wrote:
>
>
>
>
>
>Hello everybody,
>
>since the camel-as2 component was added, all master builds on
>builds.apache.org fail with:
>
>[INFO] BUILD FAILURE
>...
>[ERROR] Failed to execute goal
>org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>(generate-test-component-classes) on project camel-as2:
>Error generating source for
>org.apache.camel.component.as2.api.AS2ClientManager:
>No public non-static methods found, make sure Javadoc is available as
>project test dependency -> [Help 1]
>org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>execute goal
>org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>(generate-test-component-classes) on project camel-as2:
>Error generating source for
>org.apache.camel.component.as2.api.AS2ClientManager: No public
>non-static methods found, make sure Javadoc is available as project
>test dependency
>
>See e.g.:
>https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>
>I guess something was forgotten when adding the component? It would be
>great if somebody could fix this.
>
>Thanks,
>
>Pascal
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Andrea Cosentino-2
Locally I'm unable to reproduce this.

--
Andrea Cosentino 
----------------------------------
Apache Camel PMC Member
Apache Karaf Committer
Apache Servicemix PMC Member
Email: [hidden email]
Twitter: @oscerd2
Github: oscerd






On Wednesday, May 2, 2018, 8:12:36 AM GMT+2, Jean-Baptiste Onofré <[hidden email]> wrote:





I will too.

Regards
JB

Le 2 mai 2018 à 08:11, à 08:11, Andrea Cosentino <[hidden email]> a écrit:

>I'll have a look
>
>--
>Andrea Cosentino 
>----------------------------------
>Apache Camel PMC Member
>Apache Karaf Committer
>Apache Servicemix PMC Member
>Email: [hidden email]
>Twitter: @oscerd2
>Github: oscerd
>
>
>
>
>
>
>On Sunday, April 29, 2018, 2:42:41 PM GMT+2, Pascal Schumacher
><[hidden email]> wrote:
>
>
>
>
>
>Hello everybody,
>
>since the camel-as2 component was added, all master builds on
>builds.apache.org fail with:
>
>[INFO] BUILD FAILURE
>...
>[ERROR] Failed to execute goal
>org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>(generate-test-component-classes) on project camel-as2:
>Error generating source for
>org.apache.camel.component.as2.api.AS2ClientManager:
>No public non-static methods found, make sure Javadoc is available as
>project test dependency -> [Help 1]
>org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>execute goal
>org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>(generate-test-component-classes) on project camel-as2:
>Error generating source for
>org.apache.camel.component.as2.api.AS2ClientManager: No public
>non-static methods found, make sure Javadoc is available as project
>test dependency
>
>See e.g.:
>https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>
>I guess something was forgotten when adding the component? It would be
>great if somebody could fix this.
>
>Thanks,
>
>Pascal
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Claus Ibsen-2
In reply to this post by Pascal Schumacher
Hi

Andrea found out that missing docs is a problem, so we can just add an
basic doc file in the src/main/docs folder to make the build work.

Andrea maybe you can do this?

On Sun, Apr 29, 2018 at 2:42 PM, Pascal Schumacher
<[hidden email]> wrote:

> Hello everybody,
>
> since the camel-as2 component was added, all master builds on
> builds.apache.org fail with:
>
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal
> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
> (generate-test-component-classes) on project camel-as2:
> Error generating source for
> org.apache.camel.component.as2.api.AS2ClientManager:
> No public non-static methods found, make sure Javadoc is available as
> project test dependency -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal
> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
> (generate-test-component-classes) on project camel-as2:
> Error generating source for
> org.apache.camel.component.as2.api.AS2ClientManager: No public non-static
> methods found, make sure Javadoc is available as project test dependency
>
> See e.g.:
> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>
> I guess something was forgotten when adding the component? It would be great
> if somebody could fix this.
>
> Thanks,
>
> Pascal
>



--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Reply | Threaded
Open this post in threaded view
|

R: Re: Build fails since AS2 component was added

Andrea Cosentino-2
Sure :-)

Inviato da Yahoo Mail su Android
 
  Il mer, 2 mag, 2018 alle 9:18, Claus Ibsen<[hidden email]> ha scritto:   Hi

Andrea found out that missing docs is a problem, so we can just add an
basic doc file in the src/main/docs folder to make the build work.

Andrea maybe you can do this?

On Sun, Apr 29, 2018 at 2:42 PM, Pascal Schumacher
<[hidden email]> wrote:

> Hello everybody,
>
> since the camel-as2 component was added, all master builds on
> builds.apache.org fail with:
>
> [INFO] BUILD FAILURE
> ...
> [ERROR] Failed to execute goal
> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
> (generate-test-component-classes) on project camel-as2:
> Error generating source for
> org.apache.camel.component.as2.api.AS2ClientManager:
> No public non-static methods found, make sure Javadoc is available as
> project test dependency -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal
> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
> (generate-test-component-classes) on project camel-as2:
> Error generating source for
> org.apache.camel.component.as2.api.AS2ClientManager: No public non-static
> methods found, make sure Javadoc is available as project test dependency
>
> See e.g.:
> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>
> I guess something was forgotten when adding the component? It would be great
> if somebody could fix this.
>
> Thanks,
>
> Pascal
>



--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
 
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Pascal Schumacher
In reply to this post by Claus Ibsen-2
As the failure still occurs, I took a look and was able to replicate it
locally.

It occurs if I execute |"mvn test|" (like jenkins does) and do not have
|camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar| in my local maven repository.

If I execute |"mvn install|" the build works.

For some reason the javadoc artifact is not downloaded from the camel
snapshot repository.

What is confusing me, is that the build of |camel-box| does not display
the same problem, even though is very similar.


Am 02.05.2018 um 09:18 schrieb Claus Ibsen:

> Hi
>
> Andrea found out that missing docs is a problem, so we can just add an
> basic doc file in the src/main/docs folder to make the build work.
>
> Andrea maybe you can do this?
>
> On Sun, Apr 29, 2018 at 2:42 PM, Pascal Schumacher
> <[hidden email]> wrote:
>> Hello everybody,
>>
>> since the camel-as2 component was added, all master builds on
>> builds.apache.org fail with:
>>
>> [INFO] BUILD FAILURE
>> ...
>> [ERROR] Failed to execute goal
>> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>> (generate-test-component-classes) on project camel-as2:
>> Error generating source for
>> org.apache.camel.component.as2.api.AS2ClientManager:
>> No public non-static methods found, make sure Javadoc is available as
>> project test dependency -> [Help 1]
>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
>> goal
>> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>> (generate-test-component-classes) on project camel-as2:
>> Error generating source for
>> org.apache.camel.component.as2.api.AS2ClientManager: No public non-static
>> methods found, make sure Javadoc is available as project test dependency
>>
>> See e.g.:
>> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>>
>> I guess something was forgotten when adding the component? It would be great
>> if somebody could fix this.
>>
>> Thanks,
>>
>> Pascal
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Zoran Regvart-2
Hi Cameleers,
I think I've found the core issue and committed a solution, we'll see
how the build goes.

The issue was that we were using <classifier> to reference a javadoc
dependency, whereas we should be using <type>. I think when a
multi-module Maven build is run without the goal that produces the
artifact the <classifier> resolves the dependency as pointing to the
modules `target/classes` directory instead of the artifact that is
previously built, cached or available in a remote repository. This
changes if the artifact is already present in the Maven reactor, and
then it points to the artifact built in the target directory. And
again it changes if <classifier> is switched with <type> to resolve
from local repository or, I would assume, from remote repository.

I could see this when running `mvn -X install` and `mvn -X test` -
that would fail; in `components/camel-as2` directory. The first would
output:

[DEBUG] Adding project path
file:/.../components/camel-as2/camel-as2-api/target/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar

And the second would output:

[DEBUG] Adding project path
file:/.../components/camel-as2/camel-as2-api/target/classes/

This changed when I changed the <classifier> to a <type> and now when
I run `mvn test` the javadoc dependency is picked up from my local
repository:

[DEBUG] Adding project path
file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar

I've changed all components that had <classifier>javadoc</classifier>
to <type>javadoc</type>, I hope this helps :)

zoran

On Sun, May 6, 2018 at 8:08 PM, Pascal Schumacher
<[hidden email]> wrote:

> As the failure still occurs, I took a look and was able to replicate it
> locally.
>
> It occurs if I execute |"mvn test|" (like jenkins does) and do not have
> |camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar| in my local maven repository.
>
> If I execute |"mvn install|" the build works.
>
> For some reason the javadoc artifact is not downloaded from the camel
> snapshot repository.
>
> What is confusing me, is that the build of |camel-box| does not display the
> same problem, even though is very similar.
>
>
>
> Am 02.05.2018 um 09:18 schrieb Claus Ibsen:
>>
>> Hi
>>
>> Andrea found out that missing docs is a problem, so we can just add an
>> basic doc file in the src/main/docs folder to make the build work.
>>
>> Andrea maybe you can do this?
>>
>> On Sun, Apr 29, 2018 at 2:42 PM, Pascal Schumacher
>> <[hidden email]> wrote:
>>>
>>> Hello everybody,
>>>
>>> since the camel-as2 component was added, all master builds on
>>> builds.apache.org fail with:
>>>
>>> [INFO] BUILD FAILURE
>>> ...
>>> [ERROR] Failed to execute goal
>>>
>>> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>>> (generate-test-component-classes) on project camel-as2:
>>> Error generating source for
>>> org.apache.camel.component.as2.api.AS2ClientManager:
>>> No public non-static methods found, make sure Javadoc is available as
>>> project test dependency -> [Help 1]
>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
>>> goal
>>>
>>> org.apache.camel:camel-api-component-maven-plugin:2.22.0-SNAPSHOT:fromApis
>>> (generate-test-component-classes) on project camel-as2:
>>> Error generating source for
>>> org.apache.camel.component.as2.api.AS2ClientManager: No public non-static
>>> methods found, make sure Javadoc is available as project test dependency
>>>
>>> See e.g.:
>>>
>>> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/256/console
>>>
>>> I guess something was forgotten when adding the component? It would be
>>> great
>>> if somebody could fix this.
>>>
>>> Thanks,
>>>
>>> Pascal
>>>
>>
>>
>



--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added

Pascal Schumacher
Hi Zoran,

great work and great explanation, thank you very much! :)

It now works for me locally.

-Pascal

Am 07.05.2018 um 11:52 schrieb Zoran Regvart:

> Hi Cameleers,
> I think I've found the core issue and committed a solution, we'll see
> how the build goes.
>
> The issue was that we were using <classifier> to reference a javadoc
> dependency, whereas we should be using <type>. I think when a
> multi-module Maven build is run without the goal that produces the
> artifact the <classifier> resolves the dependency as pointing to the
> modules `target/classes` directory instead of the artifact that is
> previously built, cached or available in a remote repository. This
> changes if the artifact is already present in the Maven reactor, and
> then it points to the artifact built in the target directory. And
> again it changes if <classifier> is switched with <type> to resolve
> from local repository or, I would assume, from remote repository.
>
> I could see this when running `mvn -X install` and `mvn -X test` -
> that would fail; in `components/camel-as2` directory. The first would
> output:
>
> [DEBUG] Adding project path
> file:/.../components/camel-as2/camel-as2-api/target/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>
> And the second would output:
>
> [DEBUG] Adding project path
> file:/.../components/camel-as2/camel-as2-api/target/classes/
>
> This changed when I changed the <classifier> to a <type> and now when
> I run `mvn test` the javadoc dependency is picked up from my local
> repository:
>
> [DEBUG] Adding project path
> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>
> I've changed all components that had <classifier>javadoc</classifier>
> to <type>javadoc</type>, I hope this helps :)
>
> zoran

Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Pascal Schumacher
The AS2 related failure is gone! :)

https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/284/console

Sadly the build remains broken due because of the recently added
camel-example-ceylon:

[ERROR] Failed to execute goal
org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency (dependency)
on project camel-example-ceylon: Cannot import module
maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT: Jar file
/home/jenkins/jenkins-slave/workspace/Camel_master-CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/camel-core/target/classes
is a directory (must be a file) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
(dependency) on project camel-example-ceylon: Cannot import module
maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT

Despite numerous tries (and already some hacky commits) we haven't been
able to fix this.

At this point I suggest we revert this addition.

Are there any objections?

-Pascal

Am 07.05.2018 um 19:27 schrieb Pascal Schumacher:

> Hi Zoran,
>
> great work and great explanation, thank you very much! :)
>
> It now works for me locally.
>
> -Pascal
>
> Am 07.05.2018 um 11:52 schrieb Zoran Regvart:
>> Hi Cameleers,
>> I think I've found the core issue and committed a solution, we'll see
>> how the build goes.
>>
>> The issue was that we were using <classifier> to reference a javadoc
>> dependency, whereas we should be using <type>. I think when a
>> multi-module Maven build is run without the goal that produces the
>> artifact the <classifier> resolves the dependency as pointing to the
>> modules `target/classes` directory instead of the artifact that is
>> previously built, cached or available in a remote repository. This
>> changes if the artifact is already present in the Maven reactor, and
>> then it points to the artifact built in the target directory. And
>> again it changes if <classifier> is switched with <type> to resolve
>> from local repository or, I would assume, from remote repository.
>>
>> I could see this when running `mvn -X install` and `mvn -X test` -
>> that would fail; in `components/camel-as2` directory. The first would
>> output:
>>
>> [DEBUG] Adding project path
>> file:/.../components/camel-as2/camel-as2-api/target/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>>
>>
>> And the second would output:
>>
>> [DEBUG] Adding project path
>> file:/.../components/camel-as2/camel-as2-api/target/classes/
>>
>> This changed when I changed the <classifier> to a <type> and now when
>> I run `mvn test` the javadoc dependency is picked up from my local
>> repository:
>>
>> [DEBUG] Adding project path
>> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>>
>>
>> I've changed all components that had <classifier>javadoc</classifier>
>> to <type>javadoc</type>, I hope this helps :)
>>
>> zoran
>

Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Zoran Regvart-2
Hi Pascal, Cameleers,
let me have a stab at it tomorrow, but baring that yeah I agree -- we
don't have the resources to maintain such an example perhaps it would
be best to remove it...

zoran

On Mon, May 7, 2018 at 9:09 PM, Pascal Schumacher
<[hidden email]> wrote:

> The AS2 related failure is gone! :)
>
> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/284/console
>
> Sadly the build remains broken due because of the recently added
> camel-example-ceylon:
>
> [ERROR] Failed to execute goal
> org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency (dependency) on
> project camel-example-ceylon: Cannot import module
> maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT: Jar file
> /home/jenkins/jenkins-slave/workspace/Camel_master-CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/camel-core/target/classes
> is a directory (must be a file) -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
> (dependency) on project camel-example-ceylon: Cannot import module
> maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT
>
> Despite numerous tries (and already some hacky commits) we haven't been able
> to fix this.
>
> At this point I suggest we revert this addition.
>
> Are there any objections?
>
> -Pascal
>
> Am 07.05.2018 um 19:27 schrieb Pascal Schumacher:
>>
>> Hi Zoran,
>>
>> great work and great explanation, thank you very much! :)
>>
>> It now works for me locally.
>>
>> -Pascal
>>
>> Am 07.05.2018 um 11:52 schrieb Zoran Regvart:
>>>
>>> Hi Cameleers,
>>> I think I've found the core issue and committed a solution, we'll see
>>> how the build goes.
>>>
>>> The issue was that we were using <classifier> to reference a javadoc
>>> dependency, whereas we should be using <type>. I think when a
>>> multi-module Maven build is run without the goal that produces the
>>> artifact the <classifier> resolves the dependency as pointing to the
>>> modules `target/classes` directory instead of the artifact that is
>>> previously built, cached or available in a remote repository. This
>>> changes if the artifact is already present in the Maven reactor, and
>>> then it points to the artifact built in the target directory. And
>>> again it changes if <classifier> is switched with <type> to resolve
>>> from local repository or, I would assume, from remote repository.
>>>
>>> I could see this when running `mvn -X install` and `mvn -X test` -
>>> that would fail; in `components/camel-as2` directory. The first would
>>> output:
>>>
>>> [DEBUG] Adding project path
>>>
>>> file:/.../components/camel-as2/camel-as2-api/target/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>>>
>>> And the second would output:
>>>
>>> [DEBUG] Adding project path
>>> file:/.../components/camel-as2/camel-as2-api/target/classes/
>>>
>>> This changed when I changed the <classifier> to a <type> and now when
>>> I run `mvn test` the javadoc dependency is picked up from my local
>>> repository:
>>>
>>> [DEBUG] Adding project path
>>>
>>> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>>>
>>> I've changed all components that had <classifier>javadoc</classifier>
>>> to <type>javadoc</type>, I hope this helps :)
>>>
>>> zoran
>>
>>
>



--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Willem.Jiang
Administrator
It looks like the ceylon-maven-plugin doesn't look up the jar files from
the .m2 repository.
Not sure if we can do the same magic of java doc here.

BTW, I build the example separately without any issue.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Tue, May 8, 2018 at 5:26 AM, Zoran Regvart <[hidden email]> wrote:

> Hi Pascal, Cameleers,
> let me have a stab at it tomorrow, but baring that yeah I agree -- we
> don't have the resources to maintain such an example perhaps it would
> be best to remove it...
>
> zoran
>
> On Mon, May 7, 2018 at 9:09 PM, Pascal Schumacher
> <[hidden email]> wrote:
> > The AS2 related failure is gone! :)
> >
> > https://builds.apache.org/view/C/view/Apache%20Camel/
> job/Camel/job/master/284/console
> >
> > Sadly the build remains broken due because of the recently added
> > camel-example-ceylon:
> >
> > [ERROR] Failed to execute goal
> > org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
> (dependency) on
> > project camel-example-ceylon: Cannot import module
> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT: Jar file
> > /home/jenkins/jenkins-slave/workspace/Camel_master-
> CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/camel-
> core/target/classes
> > is a directory (must be a file) -> [Help 1]
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
> > (dependency) on project camel-example-ceylon: Cannot import module
> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT
> >
> > Despite numerous tries (and already some hacky commits) we haven't been
> able
> > to fix this.
> >
> > At this point I suggest we revert this addition.
> >
> > Are there any objections?
> >
> > -Pascal
> >
> > Am 07.05.2018 um 19:27 schrieb Pascal Schumacher:
> >>
> >> Hi Zoran,
> >>
> >> great work and great explanation, thank you very much! :)
> >>
> >> It now works for me locally.
> >>
> >> -Pascal
> >>
> >> Am 07.05.2018 um 11:52 schrieb Zoran Regvart:
> >>>
> >>> Hi Cameleers,
> >>> I think I've found the core issue and committed a solution, we'll see
> >>> how the build goes.
> >>>
> >>> The issue was that we were using <classifier> to reference a javadoc
> >>> dependency, whereas we should be using <type>. I think when a
> >>> multi-module Maven build is run without the goal that produces the
> >>> artifact the <classifier> resolves the dependency as pointing to the
> >>> modules `target/classes` directory instead of the artifact that is
> >>> previously built, cached or available in a remote repository. This
> >>> changes if the artifact is already present in the Maven reactor, and
> >>> then it points to the artifact built in the target directory. And
> >>> again it changes if <classifier> is switched with <type> to resolve
> >>> from local repository or, I would assume, from remote repository.
> >>>
> >>> I could see this when running `mvn -X install` and `mvn -X test` -
> >>> that would fail; in `components/camel-as2` directory. The first would
> >>> output:
> >>>
> >>> [DEBUG] Adding project path
> >>>
> >>> file:/.../components/camel-as2/camel-as2-api/target/
> camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
> >>>
> >>> And the second would output:
> >>>
> >>> [DEBUG] Adding project path
> >>> file:/.../components/camel-as2/camel-as2-api/target/classes/
> >>>
> >>> This changed when I changed the <classifier> to a <type> and now when
> >>> I run `mvn test` the javadoc dependency is picked up from my local
> >>> repository:
> >>>
> >>> [DEBUG] Adding project path
> >>>
> >>> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.
> 22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
> >>>
> >>> I've changed all components that had <classifier>javadoc</classifier>
> >>> to <type>javadoc</type>, I hope this helps :)
> >>>
> >>> zoran
> >>
> >>
> >
>
>
>
> --
> Zoran Regvart
>
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Andrea Cosentino-2
We have this fix now to merge:

https://github.com/apache/camel/pull/2325

Thinking on long-term I believe we need to move examples like these in other repositories, with other stuff like camel-scala etc.

--
Andrea Cosentino 
----------------------------------
Apache Camel PMC Member
Apache Karaf Committer
Apache Servicemix PMC Member
Email: [hidden email]
Twitter: @oscerd2
Github: oscerd






On Tuesday, May 8, 2018, 12:13:09 AM GMT+2, Willem Jiang <[hidden email]> wrote:





It looks like the ceylon-maven-plugin doesn't look up the jar files from
the .m2 repository.
Not sure if we can do the same magic of java doc here.

BTW, I build the example separately without any issue.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Tue, May 8, 2018 at 5:26 AM, Zoran Regvart <[hidden email]> wrote:

> Hi Pascal, Cameleers,
> let me have a stab at it tomorrow, but baring that yeah I agree -- we
> don't have the resources to maintain such an example perhaps it would
> be best to remove it...
>
> zoran
>
> On Mon, May 7, 2018 at 9:09 PM, Pascal Schumacher
> <[hidden email]> wrote:
> > The AS2 related failure is gone! :)
> >
> > https://builds.apache.org/view/C/view/Apache%20Camel/
> job/Camel/job/master/284/console
> >
> > Sadly the build remains broken due because of the recently added
> > camel-example-ceylon:
> >
> > [ERROR] Failed to execute goal
> > org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
> (dependency) on
> > project camel-example-ceylon: Cannot import module
> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT: Jar file
> > /home/jenkins/jenkins-slave/workspace/Camel_master-
> CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/camel-
> core/target/classes
> > is a directory (must be a file) -> [Help 1]
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
> > (dependency) on project camel-example-ceylon: Cannot import module
> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT
> >
> > Despite numerous tries (and already some hacky commits) we haven't been
> able
> > to fix this.
> >
> > At this point I suggest we revert this addition.
> >
> > Are there any objections?
> >
> > -Pascal
> >
> > Am 07.05.2018 um 19:27 schrieb Pascal Schumacher:
> >>
> >> Hi Zoran,
> >>
> >> great work and great explanation, thank you very much! :)
> >>
> >> It now works for me locally.
> >>
> >> -Pascal
> >>
> >> Am 07.05.2018 um 11:52 schrieb Zoran Regvart:
> >>>
> >>> Hi Cameleers,
> >>> I think I've found the core issue and committed a solution, we'll see
> >>> how the build goes.
> >>>
> >>> The issue was that we were using <classifier> to reference a javadoc
> >>> dependency, whereas we should be using <type>. I think when a
> >>> multi-module Maven build is run without the goal that produces the
> >>> artifact the <classifier> resolves the dependency as pointing to the
> >>> modules `target/classes` directory instead of the artifact that is
> >>> previously built, cached or available in a remote repository. This
> >>> changes if the artifact is already present in the Maven reactor, and
> >>> then it points to the artifact built in the target directory. And
> >>> again it changes if <classifier> is switched with <type> to resolve
> >>> from local repository or, I would assume, from remote repository.
> >>>
> >>> I could see this when running `mvn -X install` and `mvn -X test` -
> >>> that would fail; in `components/camel-as2` directory. The first would
> >>> output:
> >>>
> >>> [DEBUG] Adding project path
> >>>
> >>> file:/.../components/camel-as2/camel-as2-api/target/
> camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
> >>>
> >>> And the second would output:
> >>>
> >>> [DEBUG] Adding project path
> >>> file:/.../components/camel-as2/camel-as2-api/target/classes/
> >>>
> >>> This changed when I changed the <classifier> to a <type> and now when
> >>> I run `mvn test` the javadoc dependency is picked up from my local
> >>> repository:
> >>>
> >>> [DEBUG] Adding project path
> >>>
> >>> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.
> 22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
> >>>
> >>> I've changed all components that had <classifier>javadoc</classifier>
> >>> to <type>javadoc</type>, I hope this helps :)
> >>>
> >>> zoran
> >>
> >>
> >
>
>
>
> --
> Zoran Regvart
>
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Zoran Regvart-2
Hi Andrea,
I've commented on the PR, I don't think that will fix the issue. I
have a workaround in the works and after tests complete successfully I
will push. In a nutshell the workaround consists of doing the work of
`ceylon-maven-plugin:import-dependencies` via `ant-run-plugin`, i.e.
copying camel-core and camel-jetty dependencies into a directory
structure that Ceylon compiler expects.

Fingers crossed :)

zoran

On Tue, May 8, 2018 at 10:40 AM, Andrea Cosentino
<[hidden email]> wrote:

> We have this fix now to merge:
>
> https://github.com/apache/camel/pull/2325
>
> Thinking on long-term I believe we need to move examples like these in other repositories, with other stuff like camel-scala etc.
>
> --
> Andrea Cosentino
> ----------------------------------
> Apache Camel PMC Member
> Apache Karaf Committer
> Apache Servicemix PMC Member
> Email: [hidden email]
> Twitter: @oscerd2
> Github: oscerd
>
>
>
>
>
>
> On Tuesday, May 8, 2018, 12:13:09 AM GMT+2, Willem Jiang <[hidden email]> wrote:
>
>
>
>
>
> It looks like the ceylon-maven-plugin doesn't look up the jar files from
> the .m2 repository.
> Not sure if we can do the same magic of java doc here.
>
> BTW, I build the example separately without any issue.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>           http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, May 8, 2018 at 5:26 AM, Zoran Regvart <[hidden email]> wrote:
>
>> Hi Pascal, Cameleers,
>> let me have a stab at it tomorrow, but baring that yeah I agree -- we
>> don't have the resources to maintain such an example perhaps it would
>> be best to remove it...
>>
>> zoran
>>
>> On Mon, May 7, 2018 at 9:09 PM, Pascal Schumacher
>> <[hidden email]> wrote:
>> > The AS2 related failure is gone! :)
>> >
>> > https://builds.apache.org/view/C/view/Apache%20Camel/
>> job/Camel/job/master/284/console
>> >
>> > Sadly the build remains broken due because of the recently added
>> > camel-example-ceylon:
>> >
>> > [ERROR] Failed to execute goal
>> > org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
>> (dependency) on
>> > project camel-example-ceylon: Cannot import module
>> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT: Jar file
>> > /home/jenkins/jenkins-slave/workspace/Camel_master-
>> CIGY56HHEDNGVJBWJRRHBZ64GKNJTCSYDKOPJS46W5IZTMAS3I2Q/camel-
>> core/target/classes
>> > is a directory (must be a file) -> [Help 1]
>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>> execute
>> > goal org.ceylon-lang:ceylon-maven-plugin:1.3.3:import-dependency
>> > (dependency) on project camel-example-ceylon: Cannot import module
>> > maven:org.apache.camel.camel-core/2.22.0-SNAPSHOT
>> >
>> > Despite numerous tries (and already some hacky commits) we haven't been
>> able
>> > to fix this.
>> >
>> > At this point I suggest we revert this addition.
>> >
>> > Are there any objections?
>> >
>> > -Pascal
>> >
>> > Am 07.05.2018 um 19:27 schrieb Pascal Schumacher:
>> >>
>> >> Hi Zoran,
>> >>
>> >> great work and great explanation, thank you very much! :)
>> >>
>> >> It now works for me locally.
>> >>
>> >> -Pascal
>> >>
>> >> Am 07.05.2018 um 11:52 schrieb Zoran Regvart:
>> >>>
>> >>> Hi Cameleers,
>> >>> I think I've found the core issue and committed a solution, we'll see
>> >>> how the build goes.
>> >>>
>> >>> The issue was that we were using <classifier> to reference a javadoc
>> >>> dependency, whereas we should be using <type>. I think when a
>> >>> multi-module Maven build is run without the goal that produces the
>> >>> artifact the <classifier> resolves the dependency as pointing to the
>> >>> modules `target/classes` directory instead of the artifact that is
>> >>> previously built, cached or available in a remote repository. This
>> >>> changes if the artifact is already present in the Maven reactor, and
>> >>> then it points to the artifact built in the target directory. And
>> >>> again it changes if <classifier> is switched with <type> to resolve
>> >>> from local repository or, I would assume, from remote repository.
>> >>>
>> >>> I could see this when running `mvn -X install` and `mvn -X test` -
>> >>> that would fail; in `components/camel-as2` directory. The first would
>> >>> output:
>> >>>
>> >>> [DEBUG] Adding project path
>> >>>
>> >>> file:/.../components/camel-as2/camel-as2-api/target/
>> camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>> >>>
>> >>> And the second would output:
>> >>>
>> >>> [DEBUG] Adding project path
>> >>> file:/.../components/camel-as2/camel-as2-api/target/classes/
>> >>>
>> >>> This changed when I changed the <classifier> to a <type> and now when
>> >>> I run `mvn test` the javadoc dependency is picked up from my local
>> >>> repository:
>> >>>
>> >>> [DEBUG] Adding project path
>> >>>
>> >>> file:/.../.m2/repository/org/apache/camel/camel-as2-api/2.
>> 22.0-SNAPSHOT/camel-as2-api-2.22.0-SNAPSHOT-javadoc.jar
>> >>>
>> >>> I've changed all components that had <classifier>javadoc</classifier>
>> >>> to <type>javadoc</type>, I hope this helps :)
>> >>>
>> >>> zoran
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Zoran Regvart
>>



--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Zoran Regvart-2
In reply to this post by Pascal Schumacher
Hi Cameleers,
we managed to get the Ceylon example to compile without the JAR
artefact being attached to the Maven reactor, this was required by the
Ceylon Maven plugin's goal to import dependencies. You can take a look
at this commit[1] for the details of the workaround.

Now we have 21 tests that have failed, I'll try to take a look at some
of those, if anyone else has some time to take a look that would be
very welcome, ping me on IRC or Gitter so we don't overlap.

Thanks to everyone on this effort, I now it's a bit tedious and the
long iteration times slow you down

zoran

[1] https://gitbox.apache.org/repos/asf?p=camel.git;a=commitdiff;h=4851da7738ac9dede4cb7f823ccce85bf6a8d4e5
--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Pascal Schumacher
Hi Zoran,

thank you very much for fixing this. :)

-Pascal

Am 09.05.2018 um 10:10 schrieb Zoran Regvart:

> Hi Cameleers,
> we managed to get the Ceylon example to compile without the JAR
> artefact being attached to the Maven reactor, this was required by the
> Ceylon Maven plugin's goal to import dependencies. You can take a look
> at this commit[1] for the details of the workaround.
>
> Now we have 21 tests that have failed, I'll try to take a look at some
> of those, if anyone else has some time to take a look that would be
> very welcome, ping me on IRC or Gitter so we don't overlap.
>
> Thanks to everyone on this effort, I now it's a bit tedious and the
> long iteration times slow you down
>
> zoran
>
> [1] https://gitbox.apache.org/repos/asf?p=camel.git;a=commitdiff;h=4851da7738ac9dede4cb7f823ccce85bf6a8d4e5


Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

onders-2
I can help with some of them by tomorrow.

On Wed, 9 May 2018 at 17:56, Pascal Schumacher <[hidden email]>
wrote:

> Hi Zoran,
>
> thank you very much for fixing this. :)
>
> -Pascal
>
> Am 09.05.2018 um 10:10 schrieb Zoran Regvart:
> > Hi Cameleers,
> > we managed to get the Ceylon example to compile without the JAR
> > artefact being attached to the Maven reactor, this was required by the
> > Ceylon Maven plugin's goal to import dependencies. You can take a look
> > at this commit[1] for the details of the workaround.
> >
> > Now we have 21 tests that have failed, I'll try to take a look at some
> > of those, if anyone else has some time to take a look that would be
> > very welcome, ping me on IRC or Gitter so we don't overlap.
> >
> > Thanks to everyone on this effort, I now it's a bit tedious and the
> > long iteration times slow you down
> >
> > zoran
> >
> > [1]
> https://gitbox.apache.org/repos/asf?p=camel.git;a=commitdiff;h=4851da7738ac9dede4cb7f823ccce85bf6a8d4e5
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Zoran Regvart-2
On Wed, May 9, 2018 at 5:40 PM, Onder SEZGIN <[hidden email]> wrote:
> I can help with some of them by tomorrow.

Awesome, thank you. I think Tomohisa is also taking a look. Now only
the camel-ejb tests are failing[1]. Its strange I can't reproduce this
locally, other failures were pretty straightforward to fix, I can't
wrap my head around this one,

zoran

[1] https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/lastCompletedBuild/testReport/
--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Tomohisa Igarashi
Yep, actually this fails for me. I noticed that I get this weird exception when I run "mvn test -Dtest=GreaterTest"
-----------------------------
WARNING - Unable to scrape for @Stateful, @Stateless, @Singleton or @MessageDriven annotations. AnnotationFinder failed.
java.lang.RuntimeException
        at org.apache.xbean.asm5.MethodVisitor.visitParameter(Unknown Source)
        at org.apache.xbean.asm5.ClassReader.b(Unknown Source)
        at org.apache.xbean.asm5.ClassReader.accept(Unknown Source)
        at org.apache.xbean.asm5.ClassReader.accept(Unknown Source)
        at org.apache.xbean.finder.AnnotationFinder.readClassDef(AnnotationFinder.java:1170)
...
-----------------------------

I found a SO thread saying OpenEJB 4.6 + JDK8 get similar symptom, but we're using OpenEJB 4.7.5 and shouldn't be a problem...

Thanks,
Tomo

On Thu, 2018-05-10 at 00:09 +0200, Zoran Regvart wrote:

> On Wed, May 9, 2018 at 5:40 PM, Onder SEZGIN <[hidden email]> wrote:
> > I can help with some of them by tomorrow.
>
> Awesome, thank you. I think Tomohisa is also taking a look. Now only
> the camel-ejb tests are failing[1]. Its strange I can't reproduce this
> locally, other failures were pretty straightforward to fix, I can't
> wrap my head around this one,
>
> zoran
>
> [1] https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/master/lastCompletedBuild/testReport/
Reply | Threaded
Open this post in threaded view
|

Re: Build fails since AS2 component was added (camel-example-ceylon breaks build)

Onder SEZGIN
Interestingly, it does not fail in IDE(intellij).
It fails on mvn prompt as Tomohisa mentioned.
after running mvn clean on the prompt and fire the test on IDE, it is ok.
i did not dive into it yet.
this is my initial observation.

On Thu, May 10, 2018 at 1:16 AM, Tomohisa Igarashi <[hidden email]>
wrote:

> Yep, actually this fails for me. I noticed that I get this weird exception
> when I run "mvn test -Dtest=GreaterTest"
> -----------------------------
> WARNING - Unable to scrape for @Stateful, @Stateless, @Singleton or
> @MessageDriven annotations. AnnotationFinder failed.
> java.lang.RuntimeException
>         at org.apache.xbean.asm5.MethodVisitor.visitParameter(Unknown
> Source)
>         at org.apache.xbean.asm5.ClassReader.b(Unknown Source)
>         at org.apache.xbean.asm5.ClassReader.accept(Unknown Source)
>         at org.apache.xbean.asm5.ClassReader.accept(Unknown Source)
>         at org.apache.xbean.finder.AnnotationFinder.readClassDef(
> AnnotationFinder.java:1170)
> ...
> -----------------------------
>
> I found a SO thread saying OpenEJB 4.6 + JDK8 get similar symptom, but
> we're using OpenEJB 4.7.5 and shouldn't be a problem...
>
> Thanks,
> Tomo
>
> On Thu, 2018-05-10 at 00:09 +0200, Zoran Regvart wrote:
> > On Wed, May 9, 2018 at 5:40 PM, Onder SEZGIN <[hidden email]> wrote:
> > > I can help with some of them by tomorrow.
> >
> > Awesome, thank you. I think Tomohisa is also taking a look. Now only
> > the camel-ejb tests are failing[1]. Its strange I can't reproduce this
> > locally, other failures were pretty straightforward to fix, I can't
> > wrap my head around this one,
> >
> > zoran
> >
> > [1] https://builds.apache.org/view/C/view/Apache%20Camel/
> job/Camel/job/master/lastCompletedBuild/testReport/
>
12