[GitHub] [camel] AemieJ opened a new pull request #3893: CAMEL-14910 - Bundling of Components in reference to PR#3879

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ opened a new pull request #3893: CAMEL-14910 - Bundling of Components in reference to PR#3879

GitBox

AemieJ opened a new pull request #3893:
URL: https://github.com/apache/camel/pull/3893


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on a change in pull request #3893: CAMEL-14910 - Bundling of Components

GitBox

djencks commented on a change in pull request #3893:
URL: https://github.com/apache/camel/pull/3893#discussion_r436281590



##########
File path: components/camel-aws2-cw/src/main/docs/aws2-summary.adoc
##########
@@ -0,0 +1,33 @@
+= AWS2 Component
+:docTitle: AWS 2
+:summary-group: AWS 2
+
+*Since Camel {since}*

Review comment:
       There's no `since` attribute, and I think the AWS2 components are being added gradually, so I don't think this line is appropriate.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on a change in pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

djencks commented on a change in pull request #3893:
URL: https://github.com/apache/camel/pull/3893#discussion_r436281801



##########
File path: components/camel-google-bigquery/src/main/docs/google-summary.adoc
##########
@@ -0,0 +1,28 @@
+= Google Component
+//THIS FILE IS COPIED: EDIT THE SOURCE FILE:
+:page-source: components/camel-google/src/main/docs/google-summary.adoc

Review comment:
       If this is really copied, it shouldn't be in this commit.  This also seems like a wrong location for it in any case. Also, is the summary-group attribute getting added? I thought that since we aren't using it any more we weren't adding it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

djencks commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640086342


   I left a couple of comments.  In the future, I think it will be clearer if you force-push changes onto an existing PR rather than opening a new one.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ commented on a change in pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ commented on a change in pull request #3893:
URL: https://github.com/apache/camel/pull/3893#discussion_r436282713



##########
File path: components/camel-google-bigquery/src/main/docs/google-summary.adoc
##########
@@ -0,0 +1,28 @@
+= Google Component
+//THIS FILE IS COPIED: EDIT THE SOURCE FILE:
+:page-source: components/camel-google/src/main/docs/google-summary.adoc

Review comment:
       @djencks yes, I will remove the use of summary-group as we can make use of docTitle. Also, we discussed generating the list on `summary.adoc` using the index-list, are you still planning to perform that in the future?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ commented on a change in pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ commented on a change in pull request #3893:
URL: https://github.com/apache/camel/pull/3893#discussion_r436282812



##########
File path: components/camel-aws2-cw/src/main/docs/aws2-summary.adoc
##########
@@ -0,0 +1,33 @@
+= AWS2 Component
+:docTitle: AWS 2
+:summary-group: AWS 2
+
+*Since Camel {since}*

Review comment:
       Ok, this is the same case for both AWS and Google summary as well then. I will make the change.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640087994


   > I left a couple of comments. In the future, I think it will be clearer if you force-push changes onto an existing PR rather than opening a new one.
   
   @djencks yes, I will take care of it. Thankyou.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

djencks commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640257275


   Although it might be better to rearrange this to only have 3 commits, I think that it's fine to rebase-and-merge as is.  Any other opinions?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] zregvart commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

zregvart commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640260939


   Sorry to nitpick, can we also put the issue number in the commit message title, like `CAMEL-14910: modify gulpfile to generate bundling of components nav` and so on. This gives us links from GitHub UI to the JIRA and if we need to backport this makes the commits easier to find.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640261443


   @zregvart  note taken, I will change the commit message to include the issue number as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

oscerd commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640473862


   Please rebase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

djencks commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640086342






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640557882






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

oscerd commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640769416






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] djencks commented on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

djencks commented on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640767706


   Is anything else needed before merging this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd merged pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

oscerd merged pull request #3893:
URL: https://github.com/apache/camel/pull/3893


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] AemieJ edited a comment on pull request #3893: CAMEL-14910 - Bundling of Components

GitBox
In reply to this post by GitBox

AemieJ edited a comment on pull request #3893:
URL: https://github.com/apache/camel/pull/3893#issuecomment-640772593


   @oscerd this PR builded for me successfully. Which PR are you talking about?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]