[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming

GitBox
asifdxtreme commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323183498
 
 

 ##########
 File path: pkg/controller/integrationplatform/initialize.go
 ##########
 @@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx context.Context, platform *v1alpha1.I
  }
 
  // Check if the operator is running in the same namespace before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() && platform.Spec.Build.KanikoBuildCache {
 
 Review comment:
   @astefanutti based on your input I thought to reverse the way we are dealing with this new variable, so now the `kamel` cli tool will take the value of `skip-kaniko-build-cache` whose value will be by default `false`. Now in the intialize we skip the cache warmer only if this value has been explicitly update as `true` (`if platform.Namespace == platformutil.GetOperatorNamespace() && !platform.Spec.Build.SkipKanikoBuildCache {`). Hope this will cover most of the scenarios of installation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services