[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-k] astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming

GitBox
astefanutti commented on a change in pull request #922: fix: Add option to disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323084148
 
 

 ##########
 File path: pkg/controller/integrationplatform/initialize.go
 ##########
 @@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx context.Context, platform *v1alpha1.I
  }
 
  // Check if the operator is running in the same namespace before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() && platform.Spec.Build.KanikoBuildCache {
 
 Review comment:
   My understanding is that it defaults to `false` when the platform is not created with the `kamel` CLI, e.g. with Operator Hub, while it defaults to `true` otherwise.
   
   The `KanikoBuildCache` could be a `*bool`, whose value is defaulted to `true` during the platform initialisation phase if the pointer is `nil`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services