[GitHub] [camel] lburgazzoli opened a new pull request #3850: Add a way to easily call a bean method when an camel lifecycle event happen

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] lburgazzoli opened a new pull request #3850: Add a way to easily call a bean method when an camel lifecycle event happen

GitBox

lburgazzoli opened a new pull request #3850:
URL: https://github.com/apache/camel/pull/3850


   From https://github.com/apache/camel-k-runtime/issues/324
   
   
   [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] lburgazzoli commented on pull request #3850: Add a way to easily call a bean method when a camel lifecycle event happen

GitBox

lburgazzoli commented on pull request #3850:
URL: https://github.com/apache/camel/pull/3850#issuecomment-632664510


   > I wonder if the SPI interfaces should be named `OnCamelContextXXX` as `OnContext` may be a bit ambiguous for new users to Camel that by Context we mean CamelContext. The event classes are named CamelContextXXXEvent etc.
   
   done
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] lburgazzoli merged pull request #3850: Add a way to easily call a bean method when a camel lifecycle event happen

GitBox
In reply to this post by GitBox

lburgazzoli merged pull request #3850:
URL: https://github.com/apache/camel/pull/3850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]