[GitHub] [camel] mcrmfc opened a new pull request #3958: CAMEL-15230 - fixes bug in camel-opentracing (rabbitmq decorator) - don't rely on EXCHANGE_NAME header

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] mcrmfc opened a new pull request #3958: CAMEL-15230 - fixes bug in camel-opentracing (rabbitmq decorator) - don't rely on EXCHANGE_NAME header

GitBox

mcrmfc opened a new pull request #3958:
URL: https://github.com/apache/camel/pull/3958


   The `EXCHANGE_NAME` header is not required and when it is missing this results in `null` operation names which in turn means collectors such as Jaeger will ignore the spans and ultimately you get broken traces with invalid parent spans reported.
   
   Fall through to base implementation which uses endpoint and has existing tests.
   
   [] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel] oscerd merged pull request #3958: CAMEL-15230 - fixes bug in camel-opentracing (rabbitmq decorator) - don't rely on EXCHANGE_NAME header

GitBox

oscerd merged pull request #3958:
URL: https://github.com/apache/camel/pull/3958


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]