[GitHub] [camel-quarkus] gsmet opened a new pull request #603: WIP - Prepare for Quarkus 1.2

classic Classic list List threaded Threaded
69 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576637265
 
 
   The stack trace is:
   
   ```
   2020-01-21T11:12:21.3603975Z [INFO] Running org.apache.camel.quarkus.component.xml.deployment.CamelDevModeTest
   2020-01-21T11:12:21.8279540Z 11:12:21,813 ERROR [io.qua.dev.DevModeMain] Failed to start quarkus: java.util.NoSuchElementException: Property user.country not found
   2020-01-21T11:12:21.8280322Z at io.smallrye.config.SmallRyeConfig.propertyNotFound(SmallRyeConfig.java:206)
   2020-01-21T11:12:21.8280457Z at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:96)
   2020-01-21T11:12:21.8280577Z at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:80)
   2020-01-21T11:12:21.8280713Z at io.quarkus.runtime.configuration.ConfigExpander.accept(ConfigExpander.java:55)
   2020-01-21T11:12:21.8280841Z at io.quarkus.runtime.configuration.ConfigExpander.accept(ConfigExpander.java:15)
   2020-01-21T11:12:21.8280963Z at org.wildfly.common.expression.ExpressionNode.emit(ExpressionNode.java:42)
   2020-01-21T11:12:21.8281084Z at org.wildfly.common.expression.CompositeNode.emit(CompositeNode.java:42)
   2020-01-21T11:12:21.8281206Z at org.wildfly.common.expression.Expression.evaluateException(Expression.java:75)
   2020-01-21T11:12:21.8281319Z at org.wildfly.common.expression.Expression.evaluate(Expression.java:89)
   2020-01-21T11:12:21.8281445Z at io.quarkus.runtime.configuration.ExpandingConfigSource.expandValue(ExpandingConfigSource.java:101)
   2020-01-21T11:12:21.8281573Z at io.quarkus.runtime.configuration.ExpandingConfigSource.expand(ExpandingConfigSource.java:69)
   2020-01-21T11:12:21.8281697Z at io.quarkus.runtime.configuration.ExpandingConfigSource.getValue(ExpandingConfigSource.java:47)
   2020-01-21T11:12:21.8282127Z at io.quarkus.runtime.configuration.DeploymentProfileConfigSource.getValue(DeploymentProfileConfigSource.java:80)
   2020-01-21T11:12:21.8282273Z at io.smallrye.config.SmallRyeConfig.getRawValue(SmallRyeConfig.java:121)
   2020-01-21T11:12:21.8282394Z at io.smallrye.config.SmallRyeConfig.getValue(SmallRyeConfig.java:84)
   2020-01-21T11:12:21.8282528Z at io.quarkus.deployment.configuration.BuildTimeConfigurationReader$ReadOperation.readConfigValue(BuildTimeConfigurationReader.java:589)
   2020-01-21T11:12:21.8282679Z at io.quarkus.deployment.configuration.BuildTimeConfigurationReader$ReadOperation.readConfigGroup(BuildTimeConfigurationReader.java:534)
   2020-01-21T11:12:21.8282806Z at io.quarkus.deployment.configuration.BuildTimeConfigurationReader$ReadOperation.run(BuildTimeConfigurationReader.java:273)
   2020-01-21T11:12:21.8282942Z at io.quarkus.deployment.configuration.BuildTimeConfigurationReader.readConfiguration(BuildTimeConfigurationReader.java:230)
   2020-01-21T11:12:21.8283073Z at io.quarkus.deployment.ExtensionLoader.loadStepsFrom(ExtensionLoader.java:201)
   2020-01-21T11:12:21.8283195Z at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:85)
   2020-01-21T11:12:21.8283314Z at io.quarkus.runner.RuntimeRunner.run(RuntimeRunner.java:114)
   2020-01-21T11:12:21.8283412Z at io.quarkus.dev.DevModeMain.doStart(DevModeMain.java:178)
   2020-01-21T11:12:21.8283684Z at io.quarkus.dev.DevModeMain.start(DevModeMain.java:96)
   2020-01-21T11:12:21.8283775Z at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:159)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576637350
 
 
   I was seeing that one as well....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576638299
 
 
   Hum. I think it's due to the recent addition of `LocalesBuildTimeConfig` and:
   ```
       @ConfigItem(defaultValue = "${user.language}-${user.country}", defaultValueDocumentation = "Set containing the build system locale")
       public Set<Locale> locales;
   ```
   I suppose `${user.country}` is not defined on your CI somehow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576638616
 
 
   They are GitHub Actions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576638759
 
 
   @lburgazzoli could you try adding `export LANG=en_US` to your GH actions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576638877
 
 
   I'll try to reproduce it locally and come up with a fix in Quarkus.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639016
 
 
   @gsmet I can take care of it if you like

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639183
 
 
   @geoand ah that would be nice. I think it's just about having `${user.country:}` with a colon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639547
 
 
   @gsmet you can add them to the git hub actions yamls (.github); or I can do it by changing tha file and push to the PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639721
 
 
   ah, I will try to push to the PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639959
 
 
   Building `1.2.0.CR1` locally and then I will tryu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand edited a comment on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand edited a comment on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576639959
 
 
   Building `1.2.0.CR1` locally and then I will try

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576642281
 
 
   @geoand the issue is in master too so you can just give master a shot.
   
   I think just having `export LANG=en` should trigger it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
gsmet commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576642460
 
 
   BTW, just so you know, we already properly parse `en-` to a valid locale. So it's really about making the country non-mandatory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576644897
 
 
   > BTW, just so you know, we already properly parse `en-` to a valid locale. So it's really about making the country non-mandatory.
   
   Yes, exactly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576646239
 
 
   I can't reproduce this locally

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576649369
 
 
   ```
    LANG=C.UTF-8
   LANGUAGE=
   LC_CTYPE="C.UTF-8"
   LC_NUMERIC="C.UTF-8"
   LC_TIME="C.UTF-8"
   LC_COLLATE="C.UTF-8"
   LC_MONETARY="C.UTF-8"
   LC_MESSAGES="C.UTF-8"
   LC_PAPER="C.UTF-8"
   LC_NAME="C.UTF-8"
   LC_ADDRESS="C.UTF-8"
   LC_TELEPHONE="C.UTF-8"
   LC_MEASUREMENT="C.UTF-8"
   LC_IDENTIFICATION="C.UTF-8"
   LC_ALL=
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
lburgazzoli edited a comment on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576649369
 
 
   Here what `locale ` outputs:
   ```
   LANG=C.UTF-8
   LANGUAGE=
   LC_CTYPE="C.UTF-8"
   LC_NUMERIC="C.UTF-8"
   LC_TIME="C.UTF-8"
   LC_COLLATE="C.UTF-8"
   LC_MONETARY="C.UTF-8"
   LC_MESSAGES="C.UTF-8"
   LC_PAPER="C.UTF-8"
   LC_NAME="C.UTF-8"
   LC_ADDRESS="C.UTF-8"
   LC_TELEPHONE="C.UTF-8"
   LC_MEASUREMENT="C.UTF-8"
   LC_IDENTIFICATION="C.UTF-8"
   LC_ALL=
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] geoand commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
geoand commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576653310
 
 
   I was able to reproduce this locally by `System.clearProperty("user.country")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-quarkus] lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2

GitBox
In reply to this post by GitBox
lburgazzoli commented on issue #603: WIP - Prepare for Quarkus 1.2
URL: https://github.com/apache/camel-quarkus/pull/603#issuecomment-576657761
 
 
   @geoand @gsmet I'm testing the native images on my laptop to avoid waiting for CI to kicks in, should I merge if everything is OK ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
1234