[GitHub] [camel-website] AemieJ opened a new pull request #419: fix: adjustments for the category box within blog section

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ opened a new pull request #419: fix: adjustments for the category box within blog section

GitBox

AemieJ opened a new pull request #419:
URL: https://github.com/apache/camel-website/pull/419


   ### ISSUE OBSERVED
   ![old-category](https://user-images.githubusercontent.com/44139348/86088792-9be42d00-bac4-11ea-9d56-18bedc20ddad.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #419: fix: adjustments for the category box within blog section

GitBox

zregvart commented on pull request #419:
URL: https://github.com/apache/camel-website/pull/419#issuecomment-652087310


   @AemieJ can you describe the problem with more detail, I'm not sure what is addressed here. The screenshot seems odd I can't see the "Edit this page"/"Back to top" links if I reduce the width below 1024px in Firefox or in Chromium.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on pull request #419: fix: adjustments for the category box within blog section

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #419:
URL: https://github.com/apache/camel-website/pull/419#issuecomment-652185130


   @zregvart The issue is that within the blogs section when the user scrolls to the bottom and clicks on the toolbar toggle, the menu appears with all the categories, however, there is a margin-top and it doesn't cover the full page and appears in the manner as the screenshot, it is very odd behavior and not ideal. So with the changes, I make it so that the whole category box covers the full width and there is no margin-top issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart merged pull request #419: fix: adjustments for the category box within blog section

GitBox
In reply to this post by GitBox

zregvart merged pull request #419:
URL: https://github.com/apache/camel-website/pull/419


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #419: fix: adjustments for the category box within blog section

GitBox
In reply to this post by GitBox

zregvart commented on pull request #419:
URL: https://github.com/apache/camel-website/pull/419#issuecomment-652881953


   All clear now, thanks @AemieJ!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]