[GitHub] [camel-website] jyotiattri opened a new pull request #270: New section added in frontpage

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri opened a new pull request #270: New section added in frontpage

GitBox
jyotiattri opened a new pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270
 
 
   This adds a fix for [**website - Add section to display the 6 camel projects with logos**](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-14772?filter=allopenissues)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri closed pull request #270: New section added in frontpage

GitBox
jyotiattri closed pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri opened a new pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
jyotiattri opened a new pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270
 
 
   This adds a fix for [**website - Add section to display the 6 camel projects with logos**](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-14772?filter=allopenissues)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
jyotiattri commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-604246857
 
 
   Hi @zregvart
   Is there anything that I need to do to fix the build errors?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618968
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -273,3 +277,48 @@ section.frontpage h1 {
     text-align: center;
   }
 }
+
+section.frontpage.projects-new {
+  display: flex;
+  display: -webkit-box;
+  display: -ms-flexbox;
+  flex-wrap: wrap;
+}
+
+.box-new {
+  -webkit-box-flex: 33%;
+  -ms-flex: 33%;
 
 Review comment:
   Remove browser prefixes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618822
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -273,3 +277,48 @@ section.frontpage h1 {
     text-align: center;
   }
 }
+
+section.frontpage.projects-new {
+  display: flex;
+  display: -webkit-box;
+  display: -ms-flexbox;
 
 Review comment:
   We don't add browser prefixes, we rely only on standards.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398619183
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -273,3 +277,48 @@ section.frontpage h1 {
     text-align: center;
   }
 }
+
+section.frontpage.projects-new {
+  display: flex;
+  display: -webkit-box;
+  display: -ms-flexbox;
+  flex-wrap: wrap;
+}
+
+.box-new {
+  -webkit-box-flex: 33%;
+  -ms-flex: 33%;
+  flex: 33%;
+  padding: 0.5rem 0;
+}
+
+.box-new div {
+  padding: 0.5rem;
+  margin: 0.5rem;
+  height: 100%;
+}
+
+.box-new img {
+  margin: 0 auto;
+  display: block;
+}
+
+section.frontpage .box-new h2 {
+  text-align: center;
+  text-transform: capitalize;
+  width: 100%;
+  color: var(--color-black);
+}
+
+section.frontpage .box-new p {
+  font-style: italic;
+  text-align: center;
+}
+
+section.frontpage.projects .project h2 {
+  white-space: nowrap;
+  padding: 1rem 0;
+  -webkit-box-flex: 1;
+  -ms-flex: 1;
 
 Review comment:
   Remove browser prefixes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618447
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -237,6 +237,10 @@ section.frontpage h1 {
     flex: 100%;
   }
 
+  .box-new {
 
 Review comment:
   Can't we use the existing `box` class? Naming things `-new` leads to naming the next new thing `-newer` and the thing after that one `-newest` and so on. This is never a good practice. Read [this](https://www.w3.org/QA/Tips/goodclassnames).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-604467287
 
 
   Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-270/Preview/index.html). This also needs a rebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
jyotiattri commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r399014847
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -237,6 +237,10 @@ section.frontpage h1 {
     flex: 100%;
   }
 
+  .box-new {
 
 Review comment:
   This PR is regarding [website - Add section to display the 6 camel projects with logos](https://issues.apache.org/jira/browse/CAMEL-14772).
   I created the icons and the design according to the tweet mentioned the issue.
   I need help with SVG icons. Can you please help me with SVG icons?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
aashnajena commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-604872119
 
 
   Are the preview builds somehow broken? I see a very distorted page when I open this link on chrome. There was some inconsistency with my [PR-207](https://github.com/apache/camel-website/pull/207) also.
   
   
   ![preview](https://user-images.githubusercontent.com/32356795/77735623-e91db200-7030-11ea-8661-8e323822484c.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
jyotiattri commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-604946530
 
 
   @aashnajena, I am not sure why it is like that for you, it is working fine for me. I tested in both Firefox and Chrome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena removed a comment on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
aashnajena removed a comment on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-604872119
 
 
   Are the preview builds somehow broken? I see a very distorted page when I open this link on chrome. There was some inconsistency with my [PR-207](https://github.com/apache/camel-website/pull/207) also.
   
   
   ![preview](https://user-images.githubusercontent.com/32356795/77735623-e91db200-7030-11ea-8661-8e323822484c.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r399824699
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -237,6 +237,10 @@ section.frontpage h1 {
     flex: 100%;
   }
 
+  .box-new {
 
 Review comment:
   We have Apache Camel logo [here](https://github.com/apache/camel/tree/master/docs/img) not sure how Claus created that image in the tweet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] jyotiattri commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
jyotiattri commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-607260503
 
 
   In this, I have made changes in CSS and Add svg images into it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402228852
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -290,3 +291,37 @@ section.frontpage h2 {
     text-align: center;
   }
 }
+
+section.frontpage.camelProjects {
+  display: flex;
+  flex-wrap: wrap;
+}
+
+.projectDetails {
+  flex: 33%;
+  padding: 0.5rem 0;
+}
+
+.projectDetails div {
+  padding: 0.5rem;
+  margin: 0.5rem;
+  height: 100%;
+}
+
+.projectDetails img {
+  margin: 0 auto;
+  display: block;
+  width: 60%;
+}
+
+section.frontpage .projectDetails h2 {
+  text-align: center;
+  text-transform: capitalize;
+  width: 100%;
+  color: var(--heading-font-color);
+}
+
+section.frontpage .projectDetails p {
+  font-style: italic;
 
 Review comment:
   Remove italic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402228684
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -246,7 +246,8 @@ section.frontpage h2 {
 }
 
 @media screen and (max-width: 626px) {
-  .split {
+  .split,
+  .projectDetails {
 
 Review comment:
   projectDetails -> platforms

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402227595
 
 

 ##########
 File path: content/_index.md
 ##########
 @@ -53,55 +53,67 @@ Camel supports around 50 data formats, allowing to <mark>translate messages</mar
 
 {{< /section >}}
 
-{{< section "frontpage projects" >}}
-{{< div "project" >}}
-# Camel
-
-**Apache Camel** is the *Swiss knife* of integration.
-
-<a class="significant" href="./manual/latest/">Read the docs</a>
-<a class="significant" href="./components/latest/eips/enterprise-integration-patterns.html">EIP reference</a>
-<a class="significant" href="./components/latest/">Component reference</a>
-{{< /div >}}
-
-{{< div "project" >}}
-# Camel K
+{{< section "frontpage camelProjects" >}}
+# Apache Camel 3 - Projects
 
 Review comment:
   ```suggestion
   # Platforms Camel runs on
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on issue #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on issue #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#issuecomment-607798039
 
 
   Camel logo [we already](https://github.com/apache/camel-website/blob/master/antora-ui-camel/src/img/logo-d.svg) have on the website (look at the footer)
   
   Here are optimized versions of other logos you can use [logos.zip](https://github.com/apache/camel-website/files/4420786/logos.zip)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage

GitBox
In reply to this post by GitBox
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r403912704
 
 

 ##########
 File path: antora-ui-camel/src/css/frontpage.css
 ##########
 @@ -290,3 +291,63 @@ section.frontpage h2 {
     text-align: center;
   }
 }
+
+section.frontpage.camelProjects {
 
 Review comment:
   camelProjects -> platforms

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
12