[GitHub] [camel-website] ppalaga opened a new pull request #368: Status badges CSS for Camel Quarkus extension pages

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga opened a new pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox

ppalaga opened a new pull request #368:
URL: https://github.com/apache/camel-website/pull/368


   This allows to have badges for since version, JVM and Native on Camel Quarkus Extension pages, like the following:
   ![image](https://user-images.githubusercontent.com/1826249/82669158-38e8b600-9c3b-11ea-98b2-618517e30e86.png)
   
   Can be tested together with https://github.com/apache/camel-quarkus/pull/1260


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox

ppalaga commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632701524


   Do I need to care for the failed CI? The failure messages do not look very informative.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

zregvart commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632712859


   @ppalaga I've restarted the build without cache and that seems to have helped preview is [here](https://deploy-preview-368--camel.netlify.app/camel-quarkus/latest/extensions/activemq.html), though I'm guessing there is no markup present in the camel-quarkus documentation at the moment to take advantage of the css.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

zregvart commented on a change in pull request #368:
URL: https://github.com/apache/camel-website/pull/368#discussion_r429269927



##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -667,3 +667,36 @@ table.tableblock thead {
   background: var(--color-smoke-90);
   font-weight: var(--body-font-weight-bold);
 }
+
+/* Status badges used in Camel Quarkus extension pages */
+div.badges p {
+  text-align: right;
+}
+
+div.badges span {
+  color: var(--color-white);
+  padding: 2px 6px 2px 6px;
+  font-weight: normal;
+  font-style: normal;
+  font-size: 0.8em;

Review comment:
       ```suggestion
     font-size: 0.8rem;
   ```

##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -667,3 +667,36 @@ table.tableblock thead {
   background: var(--color-smoke-90);
   font-weight: var(--body-font-weight-bold);
 }
+
+/* Status badges used in Camel Quarkus extension pages */
+div.badges p {
+  text-align: right;
+}
+
+div.badges span {
+  color: var(--color-white);
+  padding: 2px 6px 2px 6px;

Review comment:
       Prefer using relative values, e.g. `rem`, test by changing the base font size to see if the proportions work. This is to help folk that configure their browsers with larger/smaller default text sizes. This works for almost any usage, though sometimes using `px` makes sense, like for borders.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on a change in pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on a change in pull request #368:
URL: https://github.com/apache/camel-website/pull/368#discussion_r429276658



##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -667,3 +667,36 @@ table.tableblock thead {
   background: var(--color-smoke-90);
   font-weight: var(--body-font-weight-bold);
 }
+
+/* Status badges used in Camel Quarkus extension pages */
+div.badges p {
+  text-align: right;
+}
+
+div.badges span {
+  color: var(--color-white);
+  padding: 2px 6px 2px 6px;

Review comment:
       Thanks, done in d140a11




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on a change in pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on a change in pull request #368:
URL: https://github.com/apache/camel-website/pull/368#discussion_r429276749



##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -667,3 +667,36 @@ table.tableblock thead {
   background: var(--color-smoke-90);
   font-weight: var(--body-font-weight-bold);
 }
+
+/* Status badges used in Camel Quarkus extension pages */
+div.badges p {
+  text-align: right;
+}
+
+div.badges span {
+  color: var(--color-white);
+  padding: 2px 6px 2px 6px;
+  font-weight: normal;
+  font-style: normal;
+  font-size: 0.8em;

Review comment:
       Done in d140a11




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632721515


   > I'm guessing there is no markup present in the camel-quarkus documentation at the moment
   
   Yes, apache/camel-quarkus#1260 is blocked by the current PR :)
   
   I have tested d140a11 locally with various default font sizes in Chrome and all of them worked as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632723757


   > re-use the badge of since event for the camel componets.
   
   Producer/consumer support is another good candidate.
   
   Perhaps some UI expert can re-style these supported/unsupported badges to something less talkative, maybe some sort of ✔/✘ instead of `suṕported/unsupported`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632828038


   The CI failed again. I'd thankful for any suggestion what to do.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga edited a comment on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga edited a comment on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632828038


   The CI failed again. I'd be thankful for any suggestion what to do.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] oscerd commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

oscerd commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-632844000


   I think it's not totally reliable.. right @zregvart ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga merged pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga merged pull request #368:
URL: https://github.com/apache/camel-website/pull/368


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] ppalaga commented on pull request #368: Status badges CSS for Camel Quarkus extension pages

GitBox
In reply to this post by GitBox

ppalaga commented on pull request #368:
URL: https://github.com/apache/camel-website/pull/368#issuecomment-633710062


   Merged, as agreed with @oscerd . Let's revert in case there is any damage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]