[GitHub] [camel-website] zregvart opened a new pull request #383: chore: rebase on latest Default Antora UI

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart opened a new pull request #383: chore: rebase on latest Default Antora UI

GitBox

zregvart opened a new pull request #383:
URL: https://github.com/apache/camel-website/pull/383


   This rebases the changes we made on top of the latest state of the
   Default Antora UI. I've tweaked the bottom margin of the TOC, so that
   the items do not render beneath the explore panel (panel with the
   components/versions). And I've removed scrollbar customizations, I find
   them gimmicky and they're negatively impacting the usability.
   
   The major new feature is the new page table of content menu on the right
   of each page.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox

zregvart commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640192958


   We need to discuss this on Monday's website call, perhaps have a round of (manual) testing before we merge this. Looks okay to me, but I could be missing something.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640193400


   cc @Delawen, @AemieJ, @aashnajena


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640192958






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] djencks commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

djencks commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640766018


   This problem looks closely related to Main content column shrinks to width of content <https://gitlab.com/antora/antora-ui-default/-/issues/134> which was fixed 4 weeks ago.  I’d suggest seeing what the page looks like with the actual default UI.  If this doesn’t happen with the default UI, then the camel customizations broke something.
   
   thanks
   David Jencks
   
   > On Jun 8, 2020, at 9:57 AM, Aashna Jena <[hidden email]> wrote:
   >
   >
   > I like the menu we're getting on the right. But I have concerns about smaller screens (as shown below). Need to investigate if this is due to tweaks we made, or is this a problem with Antora default UI? I can't really find any faults in the PR as such
   >
   >  <https://user-images.githubusercontent.com/32356795/84058290-a421de80-a9d6-11ea-94c2-59b6b64f3939.png>
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/camel-website/pull/383#issuecomment-640750448>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXWHMOAAAL5BMF66RW3RVUKAPANCNFSM4NVESXXQ>.
   >
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

aashnajena commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640750448


   I like the menu we're getting on the right. But I have concerns about smaller screens (as shown below). Need to investigate if this is due to tweaks we made, or is this a problem with Antora default UI? I can't really find any faults in the PR as such
   
   ![image](https://user-images.githubusercontent.com/32356795/84058290-a421de80-a9d6-11ea-94c2-59b6b64f3939.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-640764646






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-642204783


   I would like to merge this, are we good to go? Any other issues anyone noticed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

aashnajena commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-642418959


   Looks good to me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

AemieJ commented on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-642531438


   @zregvart for the `mobile-navbar.js`, why is the section with dropdown deleted. As we haven't created the new design layout for the navbar menu, the dropdown items need to be shown.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

AemieJ commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r438730995



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       This code block shouldn't be removed with the current layout for navbar menu. The drop down items in the navbar menu aren't accessible within the preview.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ removed a comment on pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

AemieJ removed a comment on pull request #383:
URL: https://github.com/apache/camel-website/pull/383#issuecomment-642531438


   @zregvart for the `mobile-navbar.js`, why is the section with dropdown deleted. As we haven't created the new design layout for the navbar menu, the dropdown items need to be shown.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] aashnajena commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

aashnajena commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r439761418



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       I'm able to see the dropdown menus, but I'm not able to toggle the navbar-burger icon on smaller screens. Although I think this piece of code was added for the menu-dropdowns in mobile menu




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r440374581



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       I think this should be fixed with  b7d1037




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r440375020



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       I still need to restore the dropdown menus though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r440404452



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       Sub-menus should be fixed in db8ce98. @aashnajena and @AemieJ can you take another look?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] AemieJ commented on a change in pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

AemieJ commented on a change in pull request #383:
URL: https://github.com/apache/camel-website/pull/383#discussion_r440409010



##########
File path: antora-ui-camel/src/js/05-mobile-navbar.js
##########
@@ -9,12 +9,4 @@ document.addEventListener('DOMContentLoaded', function () {
       document.documentElement.classList.toggle('is-clipped--navbar')
     })
   })
-
-  var menuDropDowns = Array.prototype.slice.call(document.querySelectorAll('.has-dropdown'), 0)

Review comment:
       Yes, LGTM now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [camel-website] zregvart merged pull request #383: chore: rebase on latest Default Antora UI

GitBox
In reply to this post by GitBox

zregvart merged pull request #383:
URL: https://github.com/apache/camel-website/pull/383


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]