[HEADS UP] Git repo camel-spring-boot created

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[HEADS UP] Git repo camel-spring-boot created

gnodet
Hi everyone,

A short note to inform you that I've gone ahead and created the
camel-spring-boot repository and pushed the spring boot support PR into it.
The repository is available at:
  https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
  https://github.com/apache/camel-spring-boot

Please, from now on, push all you work on spring-boot / spring-cloud in
this repository.  I'll commit the change to the main camel repo to remove
all the spring-boot related things later day, once I get a full build
working.

Cheers,
Guillaume Nodet
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Andrea Cosentino-3
Thanks Guillaume,

How do we plan to manage the docs for Spring Boot in the end?

Maybe I missed some discussions.

Thanks.

Il giorno lun 16 dic 2019 alle ore 12:07 Guillaume Nodet <[hidden email]>
ha scritto:

> Hi everyone,
>
> A short note to inform you that I've gone ahead and created the
> camel-spring-boot repository and pushed the spring boot support PR into it.
> The repository is available at:
>   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
>   https://github.com/apache/camel-spring-boot
>
> Please, from now on, push all you work on spring-boot / spring-cloud in
> this repository.  I'll commit the change to the main camel repo to remove
> all the spring-boot related things later day, once I get a full build
> working.
>
> Cheers,
> Guillaume Nodet
>
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

gnodet
I'm planning to work on a generator this week so that we can have a
specific section in the web site about the spring boot support.
If you have other ideas, let me know...

Guillaume

Le lun. 16 déc. 2019 à 12:14, Andrea Cosentino <[hidden email]> a écrit :

> Thanks Guillaume,
>
> How do we plan to manage the docs for Spring Boot in the end?
>
> Maybe I missed some discussions.
>
> Thanks.
>
> Il giorno lun 16 dic 2019 alle ore 12:07 Guillaume Nodet <
> [hidden email]>
> ha scritto:
>
> > Hi everyone,
> >
> > A short note to inform you that I've gone ahead and created the
> > camel-spring-boot repository and pushed the spring boot support PR into
> it.
> > The repository is available at:
> >   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
> >   https://github.com/apache/camel-spring-boot
> >
> > Please, from now on, push all you work on spring-boot / spring-cloud in
> > this repository.  I'll commit the change to the main camel repo to remove
> > all the spring-boot related things later day, once I get a full build
> > working.
> >
> > Cheers,
> > Guillaume Nodet
> >
>


--
------------------------
Guillaume Nodet
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Andrea Cosentino-3
Sounds good to me.

Il giorno lun 16 dic 2019 alle ore 15:00 Guillaume Nodet <[hidden email]>
ha scritto:

> I'm planning to work on a generator this week so that we can have a
> specific section in the web site about the spring boot support.
> If you have other ideas, let me know...
>
> Guillaume
>
> Le lun. 16 déc. 2019 à 12:14, Andrea Cosentino <[hidden email]> a
> écrit :
>
> > Thanks Guillaume,
> >
> > How do we plan to manage the docs for Spring Boot in the end?
> >
> > Maybe I missed some discussions.
> >
> > Thanks.
> >
> > Il giorno lun 16 dic 2019 alle ore 12:07 Guillaume Nodet <
> > [hidden email]>
> > ha scritto:
> >
> > > Hi everyone,
> > >
> > > A short note to inform you that I've gone ahead and created the
> > > camel-spring-boot repository and pushed the spring boot support PR into
> > it.
> > > The repository is available at:
> > >   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
> > >   https://github.com/apache/camel-spring-boot
> > >
> > > Please, from now on, push all you work on spring-boot / spring-cloud in
> > > this repository.  I'll commit the change to the main camel repo to
> remove
> > > all the spring-boot related things later day, once I get a full build
> > > working.
> > >
> > > Cheers,
> > > Guillaume Nodet
> > >
> >
>
>
> --
> ------------------------
> Guillaume Nodet
>
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Claus Ibsen-2
In reply to this post by gnodet
Hi

Good work.

For building camel-spring-boot we should have a Maven profile, so you
can easily build against master SNAPSHOT of camel, eg 3.1.0-SNAPSHOT
etc currently.
And we should also have same profile to do a quick build, eg -P fastinstall
And there are a bunch of properties with versions of all sorts of 3rd
party JARs in the root pom.xml. I wonder if we can clean that up so we
only have what must be there.
And try to inherit as much from the main camel project so we dont have
duplicates and cruft to maintain twice.


On Mon, Dec 16, 2019 at 12:07 PM Guillaume Nodet <[hidden email]> wrote:

>
> Hi everyone,
>
> A short note to inform you that I've gone ahead and created the
> camel-spring-boot repository and pushed the spring boot support PR into it.
> The repository is available at:
>   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
>   https://github.com/apache/camel-spring-boot
>
> Please, from now on, push all you work on spring-boot / spring-cloud in
> this repository.  I'll commit the change to the main camel repo to remove
> all the spring-boot related things later day, once I get a full build
> working.
>
> Cheers,
> Guillaume Nodet



--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Andrea Cosentino-3
Also we need to make the build work with JDK11.
I moved the Jenkins job from main camel repo to the spring-boot one and the
JDK11 build isn't working anymore.

https://builds.apache.org/view/C/view/Apache%20Camel/job/camel.daily.sb.jdk11/271/console

Il giorno mar 17 dic 2019 alle ore 05:43 Claus Ibsen <[hidden email]>
ha scritto:

> Hi
>
> Good work.
>
> For building camel-spring-boot we should have a Maven profile, so you
> can easily build against master SNAPSHOT of camel, eg 3.1.0-SNAPSHOT
> etc currently.
> And we should also have same profile to do a quick build, eg -P fastinstall
> And there are a bunch of properties with versions of all sorts of 3rd
> party JARs in the root pom.xml. I wonder if we can clean that up so we
> only have what must be there.
> And try to inherit as much from the main camel project so we dont have
> duplicates and cruft to maintain twice.
>
>
> On Mon, Dec 16, 2019 at 12:07 PM Guillaume Nodet <[hidden email]>
> wrote:
> >
> > Hi everyone,
> >
> > A short note to inform you that I've gone ahead and created the
> > camel-spring-boot repository and pushed the spring boot support PR into
> it.
> > The repository is available at:
> >   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
> >   https://github.com/apache/camel-spring-boot
> >
> > Please, from now on, push all you work on spring-boot / spring-cloud in
> > this repository.  I'll commit the change to the main camel repo to remove
> > all the spring-boot related things later day, once I get a full build
> > working.
> >
> > Cheers,
> > Guillaume Nodet
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Andrea Cosentino-3
Another thing I noticed: in the autogenerated section of common-bin.xml for
spring boot starter, there is still a reference to camel-jaxp-starter.

Il giorno mar 17 dic 2019 alle ore 06:05 Andrea Cosentino <[hidden email]>
ha scritto:

> Also we need to make the build work with JDK11.
> I moved the Jenkins job from main camel repo to the spring-boot one and
> the JDK11 build isn't working anymore.
>
>
> https://builds.apache.org/view/C/view/Apache%20Camel/job/camel.daily.sb.jdk11/271/console
>
> Il giorno mar 17 dic 2019 alle ore 05:43 Claus Ibsen <
> [hidden email]> ha scritto:
>
>> Hi
>>
>> Good work.
>>
>> For building camel-spring-boot we should have a Maven profile, so you
>> can easily build against master SNAPSHOT of camel, eg 3.1.0-SNAPSHOT
>> etc currently.
>> And we should also have same profile to do a quick build, eg -P
>> fastinstall
>> And there are a bunch of properties with versions of all sorts of 3rd
>> party JARs in the root pom.xml. I wonder if we can clean that up so we
>> only have what must be there.
>> And try to inherit as much from the main camel project so we dont have
>> duplicates and cruft to maintain twice.
>>
>>
>> On Mon, Dec 16, 2019 at 12:07 PM Guillaume Nodet <[hidden email]>
>> wrote:
>> >
>> > Hi everyone,
>> >
>> > A short note to inform you that I've gone ahead and created the
>> > camel-spring-boot repository and pushed the spring boot support PR into
>> it.
>> > The repository is available at:
>> >   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
>> >   https://github.com/apache/camel-spring-boot
>> >
>> > Please, from now on, push all you work on spring-boot / spring-cloud in
>> > this repository.  I'll commit the change to the main camel repo to
>> remove
>> > all the spring-boot related things later day, once I get a full build
>> > working.
>> >
>> > Cheers,
>> > Guillaume Nodet
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Zoran Regvart-2
In reply to this post by gnodet
Hi Guillaume,
one option might be to generate Antora tree in the `camel-spring-boot`
and include[1] it from the main `camel` docs tree.

I'm not 100% sure if this will work cross repositories, i.e. if
`component` in `include::version@component:module:page$topic/page.adoc[]`
is looked up (also) in a different repository. This would be something
we'd need to investigate.

zoran

[1] https://docs.antora.org/antora/2.2/asciidoc/include-page/

On Mon, Dec 16, 2019 at 3:00 PM Guillaume Nodet <[hidden email]> wrote:

>
> I'm planning to work on a generator this week so that we can have a
> specific section in the web site about the spring boot support.
> If you have other ideas, let me know...
>
> Guillaume
>
> Le lun. 16 déc. 2019 à 12:14, Andrea Cosentino <[hidden email]> a écrit :
>
> > Thanks Guillaume,
> >
> > How do we plan to manage the docs for Spring Boot in the end?
> >
> > Maybe I missed some discussions.
> >
> > Thanks.
> >
> > Il giorno lun 16 dic 2019 alle ore 12:07 Guillaume Nodet <
> > [hidden email]>
> > ha scritto:
> >
> > > Hi everyone,
> > >
> > > A short note to inform you that I've gone ahead and created the
> > > camel-spring-boot repository and pushed the spring boot support PR into
> > it.
> > > The repository is available at:
> > >   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
> > >   https://github.com/apache/camel-spring-boot
> > >
> > > Please, from now on, push all you work on spring-boot / spring-cloud in
> > > this repository.  I'll commit the change to the main camel repo to remove
> > > all the spring-boot related things later day, once I get a full build
> > > working.
> > >
> > > Cheers,
> > > Guillaume Nodet
> > >
> >
>
>
> --
> ------------------------
> Guillaume Nodet



--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

David Jencks-3
For Antora, repositories are independent of components, you can have content from many repositories contribute to the same component, and using start_paths you can have a lot of component/versions in the same repository.  I haven’t looked into the situation enough to understand what your proposed “include” would do, why not just have more pages in the new repo?  This would be a “distributed component” for Antora.

My question would be more, is camel-spring-boot (conceptually) a separate Antora component?  

David Jencks

> On Dec 17, 2019, at 2:54 AM, Zoran Regvart <[hidden email]> wrote:
>
> Hi Guillaume,
> one option might be to generate Antora tree in the `camel-spring-boot`
> and include[1] it from the main `camel` docs tree.
>
> I'm not 100% sure if this will work cross repositories, i.e. if
> `component` in `include::version@component:module:page$topic/page.adoc[]`
> is looked up (also) in a different repository. This would be something
> we'd need to investigate.
>
> zoran
>
> [1] https://docs.antora.org/antora/2.2/asciidoc/include-page/
>
> On Mon, Dec 16, 2019 at 3:00 PM Guillaume Nodet <[hidden email]> wrote:
>>
>> I'm planning to work on a generator this week so that we can have a
>> specific section in the web site about the spring boot support.
>> If you have other ideas, let me know...
>>
>> Guillaume
>>
>> Le lun. 16 déc. 2019 à 12:14, Andrea Cosentino <[hidden email]> a écrit :
>>
>>> Thanks Guillaume,
>>>
>>> How do we plan to manage the docs for Spring Boot in the end?
>>>
>>> Maybe I missed some discussions.
>>>
>>> Thanks.
>>>
>>> Il giorno lun 16 dic 2019 alle ore 12:07 Guillaume Nodet <
>>> [hidden email]>
>>> ha scritto:
>>>
>>>> Hi everyone,
>>>>
>>>> A short note to inform you that I've gone ahead and created the
>>>> camel-spring-boot repository and pushed the spring boot support PR into
>>> it.
>>>> The repository is available at:
>>>>  https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
>>>>  https://github.com/apache/camel-spring-boot
>>>>
>>>> Please, from now on, push all you work on spring-boot / spring-cloud in
>>>> this repository.  I'll commit the change to the main camel repo to remove
>>>> all the spring-boot related things later day, once I get a full build
>>>> working.
>>>>
>>>> Cheers,
>>>> Guillaume Nodet
>>>>
>>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>
>
>
> --
> Zoran Regvart

Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Zoran Regvart-2
Hi David,

On Tue, Dec 17, 2019 at 6:49 PM David Jencks <[hidden email]> wrote:
> My question would be more, is camel-spring-boot (conceptually) a separate Antora component?

We currently have the Spring Boot documentation reference as a part of
the `components` Antora component and within the same page describing
the Camel component. My assumption is that we want this to remain the
same, hence include.

For example here[1] we have auto-generated bits describing properties
when a ActiveMQ component is used with Spring Boot.

With the split repository for Camel Spring Boot starters those bits
might end up being generated in that repository rather than in the
(core) camel repository. That is to account for a situation where the
starter is or isn't present and if the properties available via the
starter auto-configuration bean are in sync with the Camel component.

zoran

[1] https://camel.apache.org/components/latest/activemq-component.html#_spring_boot_auto_configuration
--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Git repo camel-spring-boot created

Claus Ibsen-2
In reply to this post by gnodet
Hi

We need to make sure the code on the master branch works with next
Camel version.

The -P dev profile nows fails with
https://issues.apache.org/jira/browse/CAMEL-14331



On Mon, Dec 16, 2019 at 12:07 PM Guillaume Nodet <[hidden email]> wrote:

>
> Hi everyone,
>
> A short note to inform you that I've gone ahead and created the
> camel-spring-boot repository and pushed the spring boot support PR into it.
> The repository is available at:
>   https://git-wip-us.apache.org/repos/asf/camel-spring-boot.git
>   https://github.com/apache/camel-spring-boot
>
> Please, from now on, push all you work on spring-boot / spring-cloud in
> this repository.  I'll commit the change to the main camel repo to remove
> all the spring-boot related things later day, once I get a full build
> working.
>
> Cheers,
> Guillaume Nodet



--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2