JUnit 5 support in camel

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

JUnit 5 support in camel

Alex Dettinger
Hi guys,

  I've started the development of a new module adding the possibility to
write base camel-test with JUnit5. So far, I've named the module
camel-test-junit5, which would lead to a family of name like
camel-test-junit5-spring, camel-test-junit5-spring-boot...

  I would like to trigger a discussion around the naming of this module as
other candidate are also valid. For instance:
  camel-test-jupiter
 camel-test-junit-jupiter


https://github.com/apache/camel/pull/3084
https://issues.apache.org/jira/browse/CAMEL-13826
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Andrea Cosentino-3
I'm always +1 with camel-test-junit5.

Il giorno mar 6 ago 2019 alle ore 17:08 Alex Dettinger <
[hidden email]> ha scritto:

> Hi guys,
>
>   I've started the development of a new module adding the possibility to
> write base camel-test with JUnit5. So far, I've named the module
> camel-test-junit5, which would lead to a family of name like
> camel-test-junit5-spring, camel-test-junit5-spring-boot...
>
>   I would like to trigger a discussion around the naming of this module as
> other candidate are also valid. For instance:
>   camel-test-jupiter
>  camel-test-junit-jupiter
>
>
> https://github.com/apache/camel/pull/3084
> https://issues.apache.org/jira/browse/CAMEL-13826
>
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Alex Dettinger
In reply to this post by Alex Dettinger
Let me summarize the current options that have been evoked so far:
camel-test-jupiter
camel-test-junit-jupiter
camel-test-junit5
camel-test5

What do you think ?
Alex


On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]> wrote:

> Hi guys,
>
>   I've started the development of a new module adding the possibility to
> write base camel-test with JUnit5. So far, I've named the module
> camel-test-junit5, which would lead to a family of name like
> camel-test-junit5-spring, camel-test-junit5-spring-boot...
>
>   I would like to trigger a discussion around the naming of this module as
> other candidate are also valid. For instance:
>   camel-test-jupiter
>  camel-test-junit-jupiter
>
>
> https://github.com/apache/camel/pull/3084
> https://issues.apache.org/jira/browse/CAMEL-13826
>
>
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Andrea Cosentino-3
Feedback are welcome.

Il giorno mar 6 ago 2019 alle ore 17:11 Alex Dettinger <
[hidden email]> ha scritto:

> Let me summarize the current options that have been evoked so far:
> camel-test-jupiter
> camel-test-junit-jupiter
> camel-test-junit5
> camel-test5
>
> What do you think ?
> Alex
>
>
> On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]>
> wrote:
>
> > Hi guys,
> >
> >   I've started the development of a new module adding the possibility to
> > write base camel-test with JUnit5. So far, I've named the module
> > camel-test-junit5, which would lead to a family of name like
> > camel-test-junit5-spring, camel-test-junit5-spring-boot...
> >
> >   I would like to trigger a discussion around the naming of this module
> as
> > other candidate are also valid. For instance:
> >   camel-test-jupiter
> >  camel-test-junit-jupiter
> >
> >
> > https://github.com/apache/camel/pull/3084
> > https://issues.apache.org/jira/browse/CAMEL-13826
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

lburgazzoli
 +1 for camel-test-junit5 as it clearly indicate what it the testing
framework using under the hoods

---
Luca Burgazzoli


On Tue, Aug 6, 2019 at 5:13 PM Andrea Cosentino <[hidden email]> wrote:

> Feedback are welcome.
>
> Il giorno mar 6 ago 2019 alle ore 17:11 Alex Dettinger <
> [hidden email]> ha scritto:
>
> > Let me summarize the current options that have been evoked so far:
> > camel-test-jupiter
> > camel-test-junit-jupiter
> > camel-test-junit5
> > camel-test5
> >
> > What do you think ?
> > Alex
> >
> >
> > On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]>
> > wrote:
> >
> > > Hi guys,
> > >
> > >   I've started the development of a new module adding the possibility
> to
> > > write base camel-test with JUnit5. So far, I've named the module
> > > camel-test-junit5, which would lead to a family of name like
> > > camel-test-junit5-spring, camel-test-junit5-spring-boot...
> > >
> > >   I would like to trigger a discussion around the naming of this module
> > as
> > > other candidate are also valid. For instance:
> > >   camel-test-jupiter
> > >  camel-test-junit-jupiter
> > >
> > >
> > > https://github.com/apache/camel/pull/3084
> > > https://issues.apache.org/jira/browse/CAMEL-13826
> > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Claus Ibsen-2
On Tue, Aug 6, 2019 at 5:23 PM Luca Burgazzoli <[hidden email]> wrote:
>
>  +1 for camel-test-junit5 as it clearly indicate what it the testing
> framework using under the hoods
>

Yeah that is a good name too, as junit is short name .


> ---
> Luca Burgazzoli
>
>
> On Tue, Aug 6, 2019 at 5:13 PM Andrea Cosentino <[hidden email]> wrote:
>
> > Feedback are welcome.
> >
> > Il giorno mar 6 ago 2019 alle ore 17:11 Alex Dettinger <
> > [hidden email]> ha scritto:
> >
> > > Let me summarize the current options that have been evoked so far:
> > > camel-test-jupiter
> > > camel-test-junit-jupiter
> > > camel-test-junit5
> > > camel-test5
> > >
> > > What do you think ?
> > > Alex
> > >
> > >
> > > On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]>
> > > wrote:
> > >
> > > > Hi guys,
> > > >
> > > >   I've started the development of a new module adding the possibility
> > to
> > > > write base camel-test with JUnit5. So far, I've named the module
> > > > camel-test-junit5, which would lead to a family of name like
> > > > camel-test-junit5-spring, camel-test-junit5-spring-boot...
> > > >
> > > >   I would like to trigger a discussion around the naming of this module
> > > as
> > > > other candidate are also valid. For instance:
> > > >   camel-test-jupiter
> > > >  camel-test-junit-jupiter
> > > >
> > > >
> > > > https://github.com/apache/camel/pull/3084
> > > > https://issues.apache.org/jira/browse/CAMEL-13826
> > > >
> > > >
> > >
> >



--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Pascal Schumacher
In reply to this post by Alex Dettinger
+1 to camel-test-junit5

Am 06.08.2019 um 17:10 schrieb Alex Dettinger:

> Let me summarize the current options that have been evoked so far:
> camel-test-jupiter
> camel-test-junit-jupiter
> camel-test-junit5
> camel-test5
>
> What do you think ?
> Alex
>
>
> On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]> wrote:
>
>> Hi guys,
>>
>>    I've started the development of a new module adding the possibility to
>> write base camel-test with JUnit5. So far, I've named the module
>> camel-test-junit5, which would lead to a family of name like
>> camel-test-junit5-spring, camel-test-junit5-spring-boot...
>>
>>    I would like to trigger a discussion around the naming of this module as
>> other candidate are also valid. For instance:
>>    camel-test-jupiter
>>   camel-test-junit-jupiter
>>
>>
>> https://github.com/apache/camel/pull/3084
>> https://issues.apache.org/jira/browse/CAMEL-13826
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Zoran Regvart-2
In reply to this post by Alex Dettinger
Hi Cameleers,
I brought up the issue of naming the JUnit 5 component without the
version and with 'jupiter' instead. The reason I brought this up is
because I think that we should shield the users from version changes
as much as possible. A version neutral name would allow us to move to
a future JUnit version without any migration step required for the
user, well, depending on the amount of backward breaking changes in
the future version. I'm afraid that we'll then create -junit6
component when that version is released.

I don't mind if it's called -junit5, I would prefer if it didn't
include any version information for the reason stated above.

zoran

On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]> wrote:

>
> Hi guys,
>
>   I've started the development of a new module adding the possibility to
> write base camel-test with JUnit5. So far, I've named the module
> camel-test-junit5, which would lead to a family of name like
> camel-test-junit5-spring, camel-test-junit5-spring-boot...
>
>   I would like to trigger a discussion around the naming of this module as
> other candidate are also valid. For instance:
>   camel-test-jupiter
>  camel-test-junit-jupiter
>
>
> https://github.com/apache/camel/pull/3084
> https://issues.apache.org/jira/browse/CAMEL-13826



--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Alex Dettinger
Hey Zoran,

  Thanks for bringing the version neutral name topic to this discussion.
As far as I can tell, the next major release of junit could even introduce
a new api with yet another name than jupiter.
But, then a good name could be camel-junit alone.

  At this stage I would support camel-test-junit5 as I think users will
find it clearer to know what is under the hood.
If anyone has new elements to bring, feel free to let us know. We still
have time to enrich our rationale.

Alex



On Wed, Aug 7, 2019 at 11:57 AM Zoran Regvart <[hidden email]> wrote:

> Hi Cameleers,
> I brought up the issue of naming the JUnit 5 component without the
> version and with 'jupiter' instead. The reason I brought this up is
> because I think that we should shield the users from version changes
> as much as possible. A version neutral name would allow us to move to
> a future JUnit version without any migration step required for the
> user, well, depending on the amount of backward breaking changes in
> the future version. I'm afraid that we'll then create -junit6
> component when that version is released.
>
> I don't mind if it's called -junit5, I would prefer if it didn't
> include any version information for the reason stated above.
>
> zoran
>
> On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]>
> wrote:
> >
> > Hi guys,
> >
> >   I've started the development of a new module adding the possibility to
> > write base camel-test with JUnit5. So far, I've named the module
> > camel-test-junit5, which would lead to a family of name like
> > camel-test-junit5-spring, camel-test-junit5-spring-boot...
> >
> >   I would like to trigger a discussion around the naming of this module
> as
> > other candidate are also valid. For instance:
> >   camel-test-jupiter
> >  camel-test-junit-jupiter
> >
> >
> > https://github.com/apache/camel/pull/3084
> > https://issues.apache.org/jira/browse/CAMEL-13826
>
>
>
> --
> Zoran Regvart
>
Reply | Threaded
Open this post in threaded view
|

Re: JUnit 5 support in camel

Willem.Jiang
Administrator
It looks like we cannot replace camel-test module right now.
+1 with camel-test-junit5.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Aug 7, 2019 at 10:29 PM Alex Dettinger <[hidden email]> wrote:

>
> Hey Zoran,
>
>   Thanks for bringing the version neutral name topic to this discussion.
> As far as I can tell, the next major release of junit could even introduce
> a new api with yet another name than jupiter.
> But, then a good name could be camel-junit alone.
>
>   At this stage I would support camel-test-junit5 as I think users will
> find it clearer to know what is under the hood.
> If anyone has new elements to bring, feel free to let us know. We still
> have time to enrich our rationale.
>
> Alex
>
>
>
> On Wed, Aug 7, 2019 at 11:57 AM Zoran Regvart <[hidden email]> wrote:
>
> > Hi Cameleers,
> > I brought up the issue of naming the JUnit 5 component without the
> > version and with 'jupiter' instead. The reason I brought this up is
> > because I think that we should shield the users from version changes
> > as much as possible. A version neutral name would allow us to move to
> > a future JUnit version without any migration step required for the
> > user, well, depending on the amount of backward breaking changes in
> > the future version. I'm afraid that we'll then create -junit6
> > component when that version is released.
> >
> > I don't mind if it's called -junit5, I would prefer if it didn't
> > include any version information for the reason stated above.
> >
> > zoran
> >
> > On Tue, Aug 6, 2019 at 5:08 PM Alex Dettinger <[hidden email]>
> > wrote:
> > >
> > > Hi guys,
> > >
> > >   I've started the development of a new module adding the possibility to
> > > write base camel-test with JUnit5. So far, I've named the module
> > > camel-test-junit5, which would lead to a family of name like
> > > camel-test-junit5-spring, camel-test-junit5-spring-boot...
> > >
> > >   I would like to trigger a discussion around the naming of this module
> > as
> > > other candidate are also valid. For instance:
> > >   camel-test-jupiter
> > >  camel-test-junit-jupiter
> > >
> > >
> > > https://github.com/apache/camel/pull/3084
> > > https://issues.apache.org/jira/browse/CAMEL-13826
> >
> >
> >
> > --
> > Zoran Regvart
> >