Re: [camel] branch master updated: Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [camel] branch master updated: Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb

Zoran Regvart-2
Hi John,

I have just a few comments on this, so I'll point to GitHub, seems
easier than commenting on a patch inline.

I think we need to use `javax.activation:javax.activation-api` here:

https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5834-L5838

And `javax.transaction:javax.transaction-api` here:

https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5849-L5852

In general I think for Camel 3.x we should remove all Maven profiles,
they do not add that much value for the end users and only help when
you build from source and activate that profile. I think the general
consensus was made that we base Camel 3.x on Java 11 (please dev@
correct me if I'm wrong on this), so removing profiles that activate
on specific Java versions would be inline with that.

2c,

zoran

On Thu, Feb 7, 2019 at 5:20 PM <[hidden email]> wrote:

>
> This is an automated email from the ASF dual-hosted git repository.
>
> jpoth pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/camel.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 1d342f5  Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb
> 1d342f5 is described below
>
> commit 1d342f5672acf202b43af0db769e4c25d40d6e38
> Author: jpoth <[hidden email]>
> AuthorDate: Thu Feb 7 17:14:43 2019 +0100
>
>     Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb

zoran
--
Zoran Regvart
Reply | Threaded
Open this post in threaded view
|

Re: [camel] branch master updated: Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb

John Poth
I agree we should aim towards removing jdk* profiles. I still see some
added value knowing we can build Camel using JDK11 albeit with some
additional logic constrained within said profiles.

Not sure about basing Camel 3 on jdk11 with the upcoming release, I'd say
it's still work in progress

On Fri, Feb 8, 2019 at 9:58 AM Zoran Regvart <[hidden email]> wrote:

> Hi John,
>
> I have just a few comments on this, so I'll point to GitHub, seems
> easier than commenting on a patch inline.
>
> I think we need to use `javax.activation:javax.activation-api` here:
>
>
> https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5834-L5838
>
> And `javax.transaction:javax.transaction-api` here:
>
>
> https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5849-L5852
>
> In general I think for Camel 3.x we should remove all Maven profiles,
> they do not add that much value for the end users and only help when
> you build from source and activate that profile. I think the general
> consensus was made that we base Camel 3.x on Java 11 (please dev@
> correct me if I'm wrong on this), so removing profiles that activate
> on specific Java versions would be inline with that.
>
> 2c,
>
> zoran
>
> On Thu, Feb 7, 2019 at 5:20 PM <[hidden email]> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > jpoth pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/camel.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >      new 1d342f5  Build on JDK-11, upgrade jaxb2-maven-plugin, use
> jakarta-jaxb
> > 1d342f5 is described below
> >
> > commit 1d342f5672acf202b43af0db769e4c25d40d6e38
> > Author: jpoth <[hidden email]>
> > AuthorDate: Thu Feb 7 17:14:43 2019 +0100
> >
> >     Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb
>
> zoran
> --
> Zoran Regvart
>
Reply | Threaded
Open this post in threaded view
|

Re: [camel] branch master updated: Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb

Zoran Regvart-2
Hi John (Foo Bar :)),
I agree, thanks for the work thus far ;)

zoran

On Fri, Feb 8, 2019 at 12:47 PM Foo Bar <[hidden email]> wrote:

>
> I agree we should aim towards removing jdk* profiles. I still see some added value knowing we can build Camel using JDK11 albeit with some additional logic constrained within said profiles.
>
> Not sure about basing Camel 3 on jdk11 with the upcoming release, I'd say it's still work in progress
>
> On Fri, Feb 8, 2019 at 9:58 AM Zoran Regvart <[hidden email]> wrote:
>>
>> Hi John,
>>
>> I have just a few comments on this, so I'll point to GitHub, seems
>> easier than commenting on a patch inline.
>>
>> I think we need to use `javax.activation:javax.activation-api` here:
>>
>> https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5834-L5838
>>
>> And `javax.transaction:javax.transaction-api` here:
>>
>> https://github.com/apache/camel/blob/c2dfbd85dca4fd51032717ea1740613c6f32a61e/parent/pom.xml#L5849-L5852
>>
>> In general I think for Camel 3.x we should remove all Maven profiles,
>> they do not add that much value for the end users and only help when
>> you build from source and activate that profile. I think the general
>> consensus was made that we base Camel 3.x on Java 11 (please dev@
>> correct me if I'm wrong on this), so removing profiles that activate
>> on specific Java versions would be inline with that.
>>
>> 2c,
>>
>> zoran
>>
>> On Thu, Feb 7, 2019 at 5:20 PM <[hidden email]> wrote:
>> >
>> > This is an automated email from the ASF dual-hosted git repository.
>> >
>> > jpoth pushed a commit to branch master
>> > in repository https://gitbox.apache.org/repos/asf/camel.git
>> >
>> >
>> > The following commit(s) were added to refs/heads/master by this push:
>> >      new 1d342f5  Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb
>> > 1d342f5 is described below
>> >
>> > commit 1d342f5672acf202b43af0db769e4c25d40d6e38
>> > Author: jpoth <[hidden email]>
>> > AuthorDate: Thu Feb 7 17:14:43 2019 +0100
>> >
>> >     Build on JDK-11, upgrade jaxb2-maven-plugin, use jakarta-jaxb
>>
>> zoran
>> --
>> Zoran Regvart



--
Zoran Regvart