[jira] Created: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
-------------------------------------------------------------------------------

                 Key: CAMEL-1049
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-spring
    Affects Versions: 1.5.0
         Environment: WinXP, JDK5
            Reporter: Andreas Kuhtz
             Fix For: 1.5.1
         Attachments: camel-shouldStartContext.patch, camel-typo.patch

The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47041#action_47041 ]

Willem Jiang commented on CAMEL-1049:
-------------------------------------

Hi Andreas,

Thanks for you patches.  Since your patches are not granted with ASF license, we can't apply them into the apache repository.
Can you resubmit the patches from this url[1] ?

BTW,
We are prefer to use svn diff to generate the patch file.

[1] https://issues.apache.org/activemq/secure/ManageAttachments.jspa?id=28454

Willem

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>             Fix For: 1.5.1
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang reassigned CAMEL-1049:
-----------------------------------

    Assignee: Willem Jiang

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment:     (was: camel-typo.patch)

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment:     (was: camel-shouldStartContext.patch)

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Fix Version/s: 2.0.0

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment: camel-shouldStartContext.patch

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment: camel-typo.patch

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47044#action_47044 ]

Andreas Kuhtz commented on CAMEL-1049:
--------------------------------------

Hi Willem,

Re-submitted the patches with ASF license and svn diff format.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CAMEL-1049.
---------------------------------

    Resolution: Fixed

Applied patches with thanks to Andreas.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz reopened CAMEL-1049:
----------------------------------


The patch was not fully applied. The setter and getter was missing. I'll attach a patch with testcase.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment:     (was: patch-1049.diff)

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment: patch-1049.diff

new patch for missing getter and setter and testcase.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated CAMEL-1049:
---------------------------------

    Attachment: patch-1049.patch

new patch with missing setter and getter. added testcase for the new attribute.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch, patch-1049.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47383#action_47383 ]

Claus Ibsen commented on CAMEL-1049:
------------------------------------

I have these setter/getter in SpringCamelContext in the trunk code


    public void setShouldStartContext(boolean shouldStartContext) {
        this.shouldStartContext = shouldStartContext;
    }

    public boolean getShouldStartContext() {
        return shouldStartContext;
    }


Why do you need the setter/getter on the CamelContextFactoryBean?


> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch, patch-1049.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47384#action_47384 ]

Andreas Kuhtz commented on CAMEL-1049:
--------------------------------------

Hi Claus,

Because the configuration want's to set this property if it is configured in the spring bean definition file. If you run the org.apache.camel.spring.config.CamelContextFactoryBeanTest with the configuration from the patch (with the new bean camel4) you can see the problem.

Andi

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch, patch-1049.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (CAMEL-1049) Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang closed CAMEL-1049.
-------------------------------

    Resolution: Fixed

The patch should be in trunk and camel-1.x branch.

> Allow configuration of shouldStartContext with Spring (CamelContextFactoryBean)
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-1049
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1049
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-spring
>    Affects Versions: 1.5.0
>         Environment: WinXP, JDK5
>            Reporter: Andreas Kuhtz
>            Assignee: Willem Jiang
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: camel-shouldStartContext.patch, camel-typo.patch, patch-1049.patch
>
>
> The shouldStartContext flag should be configurable with the spring configuration (CamelContextFactoryBean). The attached patch has the enhancements. The second patch is for a typo in a log message if the start is skipped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.