[jira] Created: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

JIRA jira@apache.org
documentation - ProcessorType needs updated javadoc for the DSL
---------------------------------------------------------------

                 Key: CAMEL-1087
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1087
             Project: Apache Camel
          Issue Type: Task
          Components: camel-core
            Reporter: Claus Ibsen
            Assignee: Claus Ibsen
             Fix For: 2.0.0


The javadoc should be reivised in ProcessorType and the other models as well as it's used for the Java DSL.

We have a few errors with copypaste etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47439#action_47439 ]

Claus Ibsen commented on CAMEL-1087:
------------------------------------

I added a few TODO in the ProcessorType  to look into. Only policy is not documented.

*interceptor*
gertv davsclaus: not sure why it returns a choicetype here
14:43 gertv davsclaus: it only appears to be adding a conditional interceptor
14:45 gertv davsclaus: sorry, the choicetype actually goes in the interceptor there, my mistake
14:45 davsclaus must be the when that triggers the choicetype to return?
14:45 davsclaus .when
14:46 gertv yes, it is
14:46 gertv but I don't know how you would use that
14:46 davsclaus ah could make sence to intercept only when predicate is true, but the return type is choice which confused me
14:47 davsclaus .intercept(header("foo").isEqualTo("bar")).to("mock:foobar") something like that?
14:47 gertv yes, that would make sense, but I don't see how you would use that from the DSL though
14:47 davsclaus yeah it laks a unit test ;)
14:47 gertv yeah, but how would you continue the route after that?
14:47 gertv because it only makes sense to intercept if you can go on with what you were doing afterwards
14:48 davsclaus ah maybe you can continue on the choice type builder?
14:48 davsclaus intercept has a proceed() and a stop() to determine what to do
14:48 davsclaus .stop() will break the route  
14:48 davsclaus .proceed() will continue from original point of interception as if nothing happened
14:49 davsclaus but better to ask the computer and add some unit tests for it ;)

*dataformat*

davsclaus btw I think we have a few to many marshal / unmarshal DSL as well that accepts the xxxType class? I was wondering why?
14:51 davsclaus see TODO in the code
14:57 gertv davsclaus: yeah, you would have expected the DataFormatClause to be implementing using the SPI classes instead of the *Type classes
14:57 gertv implenting -> implemented


> documentation - ProcessorType needs updated javadoc for the DSL
> ---------------------------------------------------------------
>
>                 Key: CAMEL-1087
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1087
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The javadoc should be reivised in ProcessorType and the other models as well as it's used for the Java DSL.
> We have a few errors with copypaste etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-1087 started by Claus Ibsen.

> documentation - ProcessorType needs updated javadoc for the DSL
> ---------------------------------------------------------------
>
>                 Key: CAMEL-1087
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1087
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The javadoc should be reivised in ProcessorType and the other models as well as it's used for the Java DSL.
> We have a few errors with copypaste etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47497#action_47497 ]

Claus Ibsen commented on CAMEL-1087:
------------------------------------

This is a task that I from time to time will work on

> documentation - ProcessorType needs updated javadoc for the DSL
> ---------------------------------------------------------------
>
>                 Key: CAMEL-1087
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1087
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The javadoc should be reivised in ProcessorType and the other models as well as it's used for the Java DSL.
> We have a few errors with copypaste etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-1087) documentation - ProcessorType needs updated javadoc for the DSL

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-1087.
--------------------------------

    Resolution: Fixed

Okay the Java DSL builders should have javadoc now

> documentation - ProcessorType needs updated javadoc for the DSL
> ---------------------------------------------------------------
>
>                 Key: CAMEL-1087
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1087
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The javadoc should be reivised in ProcessorType and the other models as well as it's used for the Java DSL.
> We have a few errors with copypaste etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.