[jira] Created: (CAMEL-1103) Delayer not working as expected.

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
Delayer not working as expected.
--------------------------------

                 Key: CAMEL-1103
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-activemq
    Affects Versions: 1.5.0
            Reporter: Markus Reil


The delayer expression is not evaluated in my route builder:

from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));

While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:

    private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
        ExpressionType expr = getExpression();
        if (expr != null) {
            if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
                return expr.createExpression(routeContext);
            }
        }
        return null;
    }

I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47496#action_47496 ]

Claus Ibsen commented on CAMEL-1103:
------------------------------------

A workaround is of course to use your own BEAN or processor to do the sleep yourself.

I am sure we will get this fixed in 1.5.1 and 2.0 in a short time. But I am a bit busy until the weekend.

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-1103:
-------------------------------

    Fix Version/s: 1.5.1
                   2.0.0
      Component/s: camel-core
                       (was: camel-activemq)

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47498#action_47498 ]

Jonathan Anstey commented on CAMEL-1103:
----------------------------------------

I'll give it a quick look since I touched the delayer last :)

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey reassigned CAMEL-1103:
--------------------------------------

    Assignee: Jonathan Anstey

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47500#action_47500 ]

Jonathan Anstey commented on CAMEL-1103:
----------------------------------------

Fixed this in rev 719041 on trunk and will shortly merge it to the 1.5 fixes branch.

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-1103) Delayer not working as expected.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey resolved CAMEL-1103.
------------------------------------

    Resolution: Fixed

> Delayer not working as expected.
> --------------------------------
>
>                 Key: CAMEL-1103
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1103
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Markus Reil
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.1, 2.0.0
>
>
> The delayer expression is not evaluated in my route builder:
> from(waitQueueName).delayer(header(HEADER_EXECUTION_TIME)).bean(routerBean).recipientList(header(HEADER_TARGET_ROUTE));
> While the recipientList expression is working the header expression is always ignored. I stepped through the code and saw that in DelayerType.createAbsoluteTimeDelayExpression() "expr.getLanguage()" is always null:
>     private Expression createAbsoluteTimeDelayExpression(RouteContext routeContext) {
>         ExpressionType expr = getExpression();
>         if (expr != null) {
>             if (ObjectHelper.isNotNullAndNonEmpty(expr.getLanguage())) {
>                 return expr.createExpression(routeContext);
>             }
>         }
>         return null;
>     }
> I have seen that this was changed in 1.5.0 (http://issues.apache.org/activemq/browse/CAMEL-811).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.