[jira] Created: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
----------------------------------------------------------------------------------------------------------------------------------

                 Key: CAMEL-390
                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
             Project: Apache Camel
          Issue Type: Improvement
            Reporter: James Strachan
            Priority: Critical
             Fix For: 1.3.0


See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-390:
----------------------------------

         Assignee: Hadrian Zbarcea
    Fix Version/s: 2.0.0
                       (was: 1.5.0)

I am not sure this is a valid issue yet.  I suspect the xml is not correct but I only have briefly looked into it.  If I understand correctly this is related to the use of refs.

It's ok for the xml doc to have one default namespace and than one element (<camelContext>) to redefine the default namespace to be something else.  However, since we are dealing with qnames, the camelContext element should define a different namespace mapping (and a prefix) for the default namespace of the document (the spring namespace) and use that to qualify the element it refs, so that resolution can happen.

But then again, I may have misunderstood the issue completely.  I'll look into it soon though.

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46256#action_46256 ]

James Strachan commented on CAMEL-390:
--------------------------------------

I think this bug was raised to try help folks figure out issues caused by the xmlns being redeclared. e.g. something like this

{code}
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="
       http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
       http://activemq.apache.org/camel/schema/spring http://activemq.apache.org/camel/schema/spring/camel-spring.xsd">

        <camelContext id="camel" useJmx="false" mbeanServer="mbeanServer"
                xmlns="http://activemq.apache.org/camel/schema/spring">
                <package>org.apache.camel.example.spring</package>
        </camelContext>

        <!-- DOES THIS FAIL? -->
        <bean id="foo" class="whatnot"/>
</beans>
{code}

I can't remember if the xmlns redeclaration of the default namespace on the <camelContext/> disappears again after the </camelContext>. Does something like the above work? If not can we generate some kinda useful error message somehow?



> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46262#action_46262 ]

Hadrian Zbarcea commented on CAMEL-390:
---------------------------------------

Isn't camel-example-print doing exactly this successfully?

The only difference is the beanServer="mbeanServer" missing.  And there is obviously no element with the id: {http://activemq.apache.org/camel/schema/spring}mbeanServer".

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46262#action_46262 ]

hadrian edited comment on CAMEL-390 at 10/8/08 10:10 AM:
-----------------------------------------------------------------

Isn't camel-example-spring doing exactly this successfully?

The only difference is the beanServer="mbeanServer" missing.  And there is obviously no element with the id: {http://activemq.apache.org/camel/schema/spring}mbeanServer".

      was (Author: hadrian):
    Isn't camel-example-print doing exactly this successfully?

The only difference is the beanServer="mbeanServer" missing.  And there is obviously no element with the id: {http://activemq.apache.org/camel/schema/spring}mbeanServer".
 

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46264#action_46264 ]

James Strachan commented on CAMEL-390:
--------------------------------------

you're right. I wonder if I was thinking of nested <bean> elements within the <camelContext/> - can't remember :)

lets just close this issue for now :)

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Strachan resolved CAMEL-390.
----------------------------------

    Fix Version/s:     (was: 2.0.0)
       Resolution: Won't Fix

not an issue AFAIK

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-390) if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-390:
----------------------------------

    Fix Version/s: 1.5.0

> if folks overload xmlns to use camel, then define beans with <bean ...> Camel should generate an error with a useful error message
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-390
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-390
>             Project: Apache Camel
>          Issue Type: Improvement
>            Reporter: James Strachan
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> See this thread... http://www.nabble.com/BeanFactoryAware-%28Spring%29-tp16122107s22882p16124218.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.