[jira] Created: (CAMEL-399) handleAll() swallows exceptions

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-399) handleAll() swallows exceptions

JIRA jira@apache.org
handleAll() swallows exceptions
-------------------------------

                 Key: CAMEL-399
                 URL: https://issues.apache.org/activemq/browse/CAMEL-399
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-core
            Reporter: Roman Kalukiewicz
            Assignee: Roman Kalukiewicz
             Fix For: 1.3.0


handleAll() section in tryBlock() swallows exceptions even if they were not catched by some handle() section so intended behavior that should mimic finally keyword from java is not accomplished.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-399) handleAll() swallows exceptions

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Kalukiewicz resolved CAMEL-399.
-------------------------------------

    Resolution: Fixed

Patch applied.

> handleAll() swallows exceptions
> -------------------------------
>
>                 Key: CAMEL-399
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-399
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: Roman Kalukiewicz
>            Assignee: Roman Kalukiewicz
>             Fix For: 1.3.0
>
>
> handleAll() section in tryBlock() swallows exceptions even if they were not catched by some handle() section so intended behavior that should mimic finally keyword from java is not accomplished.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-399) handleAll() swallows exceptions

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41816#action_41816 ]

Gary Tully commented on CAMEL-399:
----------------------------------

just one thought:
handleAll sounds like catch(Throwable) to me, to mimic the finally keyword I would expect a finallyBlock() that matches the tryBlock().

> handleAll() swallows exceptions
> -------------------------------
>
>                 Key: CAMEL-399
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-399
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: Roman Kalukiewicz
>            Assignee: Roman Kalukiewicz
>             Fix For: 1.3.0
>
>
> handleAll() section in tryBlock() swallows exceptions even if they were not catched by some handle() section so intended behavior that should mimic finally keyword from java is not accomplished.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (CAMEL-399) handleAll() swallows exceptions

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea reopened CAMEL-399:
-----------------------------------

      Assignee: Hadrian Zbarcea  (was: Roman Kalukiewicz)

The patch for this issue breaks the build.

We should also clarify the semantics based on Gary's comment.  Since handleAll could be achieved with a handle(Throwable), the missing semantics would be that of a finally block, as Roman assumed, but then we should probably change the dsl from 'handleAll' to 'finally'.

I am going to do that if there's no objection, in addition to fixing the failing test.

> handleAll() swallows exceptions
> -------------------------------
>
>                 Key: CAMEL-399
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-399
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: Roman Kalukiewicz
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.3.0
>
>
> handleAll() section in tryBlock() swallows exceptions even if they were not catched by some handle() section so intended behavior that should mimic finally keyword from java is not accomplished.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-399) handleAll() swallows exceptions

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea resolved CAMEL-399.
-----------------------------------

    Resolution: Fixed

> handleAll() swallows exceptions
> -------------------------------
>
>                 Key: CAMEL-399
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-399
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: Roman Kalukiewicz
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.3.0
>
>
> handleAll() section in tryBlock() swallows exceptions even if they were not catched by some handle() section so intended behavior that should mimic finally keyword from java is not accomplished.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.