[jira] Created: (CAMEL-460) Add spring unit tests for the intercept() feature

classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
Add spring unit tests for the intercept() feature
-------------------------------------------------

                 Key: CAMEL-460
                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
             Project: Apache Camel
          Issue Type: Test
          Components: camel-spring
    Affects Versions: 1.3.0
            Reporter: Jonathan Anstey
             Fix For: 1.4.0




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey reassigned CAMEL-460:
-------------------------------------

    Assignee: Jonathan Anstey

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>             Fix For: 1.4.0
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey updated CAMEL-460:
----------------------------------

    Attachment: camel-460.patch

I added a test case for the spring xml intercept feature... which seems to have uncovered an error... figured I'd submit this patch now to bump up the visibility of the problem.

I basically followed the schema to see how to get this

{code}
<route>
  <intercept>
    <choice>
      <when>
        <xpath>$foo = 'bar'</xpath>
        <to uri="mock:b"/>
      </when>
      <otherwise>
        <proceed/>
      </otherwise>
    </choice>
  </intercept>
</route>
<route>
  <from uri="direct:start"/>
  <to uri="mock:a"/>
</route>
{code}

from this

{code}
intercept().choice().when(header("foo").isEqualTo("bar")).to("mock:b").otherwise().proceed();

from("direct:start").to("mock:a");
{code}

Seems to be valid syntax except that the routes loaded up in the DSL are nothing like the Spring XML ones :) I think this will involve a deeper code dive!

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43358#action_43358 ]

Jonathan Anstey commented on CAMEL-460:
---------------------------------------

Oh yeah, don't forget to uncomment createCamelContext() in SpringInterceptTest to see the failing test.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang reassigned CAMEL-460:
----------------------------------

    Assignee: Willem Jiang  (was: Jonathan Anstey)

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43570#action_43570 ]

Hadrian Zbarcea commented on CAMEL-460:
---------------------------------------

Jon, that syntax wouldn't work or at least not the way you would expect.  The two <route>(s) are independent and the first route containing the <intercept> would not have the semantics of 'intercept applies to all routes'.  It's easy to fix, but we would first need agree on a syntax.  Maybe having the <intercept> under the <camelContext> ?

A few +1s or better ideas appreciated.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43573#action_43573 ]

Claus Ibsen commented on CAMEL-460:
-----------------------------------

What if the spring xml is combined in one route? That would be in line with the java DSL use-case.
Note: I haven't checked if the syntax/order of elements is valid according to the XSD.

{code}
<route>
  <intercept>
    <choice>
      <when>
        <xpath>$foo = 'bar'</xpath>
        <to uri="mock:b"/>
      </when>
      <otherwise>
        <proceed/>
      </otherwise>
    </choice>
  </intercept>
  <from uri="direct:start"/>
  <to uri="mock:a"/>
</route>
{code}



> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43572#action_43572 ]

Willem Jiang commented on CAMEL-460:
------------------------------------

I agree the we need the syntax of putting the the <intercept> under the <camelContext>.
But we need find a way to combine the RoutesType and RouteType with the CamelContextFactoryBean.

BTW InterceptType also not support take the predicate from XML,
 if I put a ChoiceType member in the interceptType , I will create a Cycle dependency between the InterceptType and ChoiceType.

Please show some light to me to  find a way to resolve it.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43577#action_43577 ]

Jonathan Anstey commented on CAMEL-460:
---------------------------------------

Thanks Hadrian for the insight into this problem. I thought though that a statement in the Java DSL would map to a route. So, this

{code}
from(foo:bar1).to(foo:bar2);
from(foo:bar2).to(foo:bar3);
{code}

would be equivalent to

{code}
<route>
  <from uri="foo:bar1"/>
  <to uri="foo:bar2"/>
</route>
<route>
  <from uri="foo:bar2"/>
  <to uri="foo:bar3"/>
</route>
{code}

Is this incorrect?

Anyways, it would make sense to have a intercept feature at a higher level up, +1 to your idea.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-460:
----------------------------------

    Fix Version/s: 1.5.0
                       (was: 1.4.0)

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43599#action_43599 ]

Hadrian Zbarcea commented on CAMEL-460:
---------------------------------------

Jon, that is correct, but that's not what the example above suggested.  intercept() is not a route and hence the intercept() in the snipped below:

{code}
intercept().to("log:foo").proceed();

from(foo:bar1).to(foo:bar2);
from(foo:bar2).to(foo:bar3);
{code}

would not translate into:

{code}
<route>
  <intercept>
  [...]
  </intercept>
</route>
{code}

Something like this may better reflect the requirement:
<camelContext>
<intercept>
  <to uri="log:foo"/>
  <proceed/>
</intercept>
<route>
  <from uri="foo:bar1"/>
  <to uri="foo:bar2"/>
</route>
<route>
  <from uri="foo:bar2"/>
  <to uri="foo:bar3"/>
</route>
</camelContext>
{code}

Note: the <proceed> will disappear after i'm done with camel-481.  Willem said it right in a mail, we have to figure out how to model RoutesType in the xml dsl.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43599#action_43599 ]

hadrian edited comment on CAMEL-460 at 6/19/08 2:03 PM:
----------------------------------------------------------------

Jon, that is correct, but that's not what the example above suggested.  intercept() is not a route and hence the intercept() in the snipped below:

{code}
intercept().to("log:foo").proceed();

from(foo:bar1).to(foo:bar2);
from(foo:bar2).to(foo:bar3);
{code}

would not translate into:

{code}
<route>
  <intercept>
  [...]
  </intercept>
</route>
{code}

Something like this may better reflect the requirement:
{code}
<camelContext>
<intercept>
  <to uri="log:foo"/>
  <proceed/>
</intercept>
<route>
  <from uri="foo:bar1"/>
  <to uri="foo:bar2"/>
</route>
<route>
  <from uri="foo:bar2"/>
  <to uri="foo:bar3"/>
</route>
</camelContext>
{code}

Note: the <proceed> will disappear after i'm done with camel-481.  

Willem said it right in a mail, we have to figure out how to model RoutesType in the xml dsl.

      was (Author: hadrian):
    Jon, that is correct, but that's not what the example above suggested.  intercept() is not a route and hence the intercept() in the snipped below:

{code}
intercept().to("log:foo").proceed();

from(foo:bar1).to(foo:bar2);
from(foo:bar2).to(foo:bar3);
{code}

would not translate into:

{code}
<route>
  <intercept>
  [...]
  </intercept>
</route>
{code}

Something like this may better reflect the requirement:
<camelContext>
<intercept>
  <to uri="log:foo"/>
  <proceed/>
</intercept>
<route>
  <from uri="foo:bar1"/>
  <to uri="foo:bar2"/>
</route>
<route>
  <from uri="foo:bar2"/>
  <to uri="foo:bar3"/>
</route>
</camelContext>
{code}

Note: the <proceed> will disappear after i'm done with camel-481.  Willem said it right in a mail, we have to figure out how to model RoutesType in the xml dsl.
 

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43621#action_43621 ]

Jonathan Anstey commented on CAMEL-460:
---------------------------------------

Yeah, makes sense. I think I was momentarily confused by Claus's comment (intercept statement and route all in one <route/>) :)

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45347#action_45347 ]

Willem Jiang commented on CAMEL-460:
------------------------------------

I just commit a patch with supporting the below configuration
{code:language=xml}
<camelContext id="camel" xmlns="http://activemq.apache.org/camel/schema/spring">
    <intercept>
      <to uri="mock:middle1"/>
    </intercept>
    <route>
      <from uri="direct:start"/>
      <to uri="mock:end"/>
    </route>
  </camelContext>
{code}

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-460 started by Willem Jiang.

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45348#action_45348 ]

Jonathan Anstey commented on CAMEL-460:
---------------------------------------

Great stuff Willem! Looks like we can close this issue now?

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45366#action_45366 ]

Claus Ibsen commented on CAMEL-460:
-----------------------------------

Willem, can you do the proceed in spring also? This is useable for those log all steps kind of interceptors?

{code:xml}
<intercept>
      <to uri="log:mylogger"/>
     <proceed/>
</intercept>
{code}

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45368#action_45368 ]

Willem Jiang commented on CAMEL-460:
------------------------------------

Hi Jonathan,

We still have the issue  of

" InterceptType also not support take the predicate from XML,
  if I put a ChoiceType member in the interceptType , I will create a Cycle dependency between the InterceptType and ChoiceType."

Maybe I need open a new JIRA for it.

Willem

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45369#action_45369 ]

Willem Jiang commented on CAMEL-460:
------------------------------------

Claus, Hadrian did some work in CAMEL-481, so we do need to specify the <proceed>  for the log any more.


> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Issue Comment Edited: (CAMEL-460) Add spring unit tests for the intercept() feature

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45372#action_45372 ]

davsclaus edited comment on CAMEL-460 at 9/3/08 8:59 PM:
-----------------------------------------------------------

Willem, ah I forgot that proceed is now default, so its the other one that might be missing - stop(). In java DSL you can use .stop(), is this supported in the spring XML as well?
{code}
<intercept>
      <to uri="bean:myspeicalbean"/>
     <stop/>
</intercept>
{code}


      was (Author: davsclaus):
    Willem, ah yeah of course proceed is now default, but then you can set stop() in the java DSL, is this supported in the spring XML as well?
{code}
<intercept>
      <to uri="bean:myspeicalbean"/>
     <stop/>
</intercept>
{code}

 

> Add spring unit tests for the intercept() feature
> -------------------------------------------------
>
>                 Key: CAMEL-460
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-460
>             Project: Apache Camel
>          Issue Type: Test
>          Components: camel-spring
>    Affects Versions: 1.3.0
>            Reporter: Jonathan Anstey
>            Assignee: Willem Jiang
>             Fix For: 1.5.0
>
>         Attachments: camel-460.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12