[jira] Created: (CAMEL-508) Some issues with creating MBeanServer

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org
Some issues with creating MBeanServer
-------------------------------------

                 Key: CAMEL-508
                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-core
            Reporter: William Tam
         Attachments: patch.txt

In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)

         if (getMBeanServer() == null) {
             // The MBeanServer was not injected
            createMBeanServer();
         }

A few side effects if not calling the createMBeanServer() method.
1. users always get platform mbean server
2. system properties processing in createMBeanServer() is bypassed
3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.

I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Tam updated CAMEL-508:
------------------------------

    Attachment: patch.txt

> Some issues with creating MBeanServer
> -------------------------------------
>
>                 Key: CAMEL-508
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: William Tam
>         Attachments: patch.txt
>
>
> In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
> the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)
>          if (getMBeanServer() == null) {
>              // The MBeanServer was not injected
>             createMBeanServer();
>          }
> A few side effects if not calling the createMBeanServer() method.
> 1. users always get platform mbean server
> 2. system properties processing in createMBeanServer() is bypassed
> 3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.
> I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang reassigned CAMEL-508:
----------------------------------

    Assignee: Willem Jiang

> Some issues with creating MBeanServer
> -------------------------------------
>
>                 Key: CAMEL-508
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: William Tam
>            Assignee: Willem Jiang
>         Attachments: patch.txt
>
>
> In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
> the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)
>          if (getMBeanServer() == null) {
>              // The MBeanServer was not injected
>             createMBeanServer();
>          }
> A few side effects if not calling the createMBeanServer() method.
> 1. users always get platform mbean server
> 2. system properties processing in createMBeanServer() is bypassed
> 3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.
> I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42755#action_42755 ]

Claus Ibsen commented on CAMEL-508:
-----------------------------------

I propose the system property is named with org.apache.camel or similar name to indicate its a system property for Camel.

We should also remember to add this feature to a JMX wiki page whenever we get one up. There is already a ticket for the documentation.

> Some issues with creating MBeanServer
> -------------------------------------
>
>                 Key: CAMEL-508
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: William Tam
>            Assignee: Willem Jiang
>         Attachments: patch.txt
>
>
> In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
> the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)
>          if (getMBeanServer() == null) {
>              // The MBeanServer was not injected
>             createMBeanServer();
>          }
> A few side effects if not calling the createMBeanServer() method.
> 1. users always get platform mbean server
> 2. system properties processing in createMBeanServer() is bypassed
> 3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.
> I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CAMEL-508.
--------------------------------

    Fix Version/s: 1.4.0
       Resolution: Fixed

I think the system property named with org.apache.camel.jmx as prefix is OK , I will head on the JMX wiki document right now .

> Some issues with creating MBeanServer
> -------------------------------------
>
>                 Key: CAMEL-508
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: William Tam
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: patch.txt
>
>
> In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
> the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)
>          if (getMBeanServer() == null) {
>              // The MBeanServer was not injected
>             createMBeanServer();
>          }
> A few side effects if not calling the createMBeanServer() method.
> 1. users always get platform mbean server
> 2. system properties processing in createMBeanServer() is bypassed
> 3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.
> I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (CAMEL-508) Some issues with creating MBeanServer

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang closed CAMEL-508.
------------------------------


> Some issues with creating MBeanServer
> -------------------------------------
>
>                 Key: CAMEL-508
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-508
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: William Tam
>            Assignee: Willem Jiang
>             Fix For: 1.4.0
>
>         Attachments: patch.txt
>
>
> In InstrumentationAgentImpl.doStart(), the method createMBeanServer() is never get invoked if mbean server  is not injected because
> the getMBeanServer() always return non-null (the getMBeanServer() method always returns the platform mbean server)
>          if (getMBeanServer() == null) {
>              // The MBeanServer was not injected
>             createMBeanServer();
>          }
> A few side effects if not calling the createMBeanServer() method.
> 1. users always get platform mbean server
> 2. system properties processing in createMBeanServer() is bypassed
> 3. jmx connector is not created as it is created indirectly by the createMBeanServer() metthod.
> I propose to invoke createMBeanServer() inside getMBeanServer() and update createMBeanServer() to read a property to determine when platform mbean should be use. (see attached patch)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.