[jira] Created: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

JIRA jira@apache.org
mina should throw exception if exchange is not out capable in sync mode
-----------------------------------------------------------------------

                 Key: CAMEL-847
                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-mina
    Affects Versions: 1.4.0
            Reporter: Claus Ibsen
            Assignee: Claus Ibsen
            Priority: Minor
             Fix For: 1.5.0


Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)

What it does now is setting the sync option itself depending on the exchange type.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45141#action_45141 ]

Claus Ibsen commented on CAMEL-847:
-----------------------------------

Hmm the current behaviour will probably break old versions where end-users have forgotten to add sync=true. If we go forward with this we should write in the release notes that people should set the sync mode explicit.

> mina should throw exception if exchange is not out capable in sync mode
> -----------------------------------------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45142#action_45142 ]

Claus Ibsen commented on CAMEL-847:
-----------------------------------

http://www.nabble.com/mina-tcp-client-problem-td19105767s22882.html

> mina should throw exception if exchange is not out capable in sync mode
> -----------------------------------------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45143#action_45143 ]

Claus Ibsen commented on CAMEL-847:
-----------------------------------

Change of tactic

I think camel-mina should be MEP agnostic and only use the sync option as:

*MinaProducer*
- if false, just send data and don't wait for response
- if true, send data and wait for response. set response on either IN or OUT depending on the MEP

*MinaConsumer*
- if false, just recieve data and don't send a response
- if true, recieve data and send the response from either IN or OUT depending on the MEP



> mina should throw exception if exchange is not out capable in sync mode
> -----------------------------------------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (CAMEL-847) mina should throw exception if exchange is not out capable in sync mode

hadrian
+1

On Aug 25, 2008, at 7:25 AM, Claus Ibsen (JIRA) wrote:

>
>    [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45143 
> #action_45143 ]
>
> Claus Ibsen commented on CAMEL-847:
> -----------------------------------
>
> Change of tactic
>
> I think camel-mina should be MEP agnostic and only use the sync  
> option as:
>
> *MinaProducer*
> - if false, just send data and don't wait for response
> - if true, send data and wait for response. set response on either  
> IN or OUT depending on the MEP
>
> *MinaConsumer*
> - if false, just recieve data and don't send a response
> - if true, recieve data and send the response from either IN or OUT  
> depending on the MEP
>
>
>
>> mina should throw exception if exchange is not out capable in sync  
>> mode
>> -----------------------------------------------------------------------
>>
>>                Key: CAMEL-847
>>                URL: https://issues.apache.org/activemq/browse/CAMEL-847
>>            Project: Apache Camel
>>         Issue Type: Improvement
>>         Components: camel-mina
>>   Affects Versions: 1.4.0
>>           Reporter: Claus Ibsen
>>           Assignee: Claus Ibsen
>>           Priority: Minor
>>            Fix For: 1.5.0
>>
>>
>> Currently the camel-mina component silently ignores exchanges that  
>> is not out capable even though its configured for sync=true (InOut)
>> What it does now is setting the sync option itself depending on the  
>> exchange type.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-847) mina should be exchange pattern agnostic

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-847:
------------------------------

     Summary: mina should be exchange pattern agnostic  (was: mina should throw exception if exchange is not out capable in sync mode)
    Priority: Major  (was: Minor)

Also it should be more spring friendly configurable using setters/getters style so we have IDE completion in spring xml files.

> mina should be exchange pattern agnostic
> ----------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (CAMEL-847) mina should be exchange pattern agnostic

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-847 started by Claus Ibsen.

> mina should be exchange pattern agnostic
> ----------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-847) mina should be exchange pattern agnostic

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45157#action_45157 ]

Claus Ibsen commented on CAMEL-847:
-----------------------------------

sync should be default true as its confusing why camel doesn't wait for a response when calling a remote server.

> mina should be exchange pattern agnostic
> ----------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-847) mina should be exchange pattern agnostic

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-847.
-------------------------------

    Resolution: Fixed

Default behavior changed

In Camel 1.5 the sync option has changed its default value from false to true, as we felt it was confusing for end-users when they used Mina to call remote servers and Camel wouldn't wait for the response.

> mina should be exchange pattern agnostic
> ----------------------------------------
>
>                 Key: CAMEL-847
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-847
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-mina
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 1.5.0
>
>
> Currently the camel-mina component silently ignores exchanges that is not out capable even though its configured for sync=true (InOut)
> What it does now is setting the sync option itself depending on the exchange type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.