[jira] Created: (CAMEL-875) Expression tokenizer should support streams

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
Expression tokenizer should support streams
-------------------------------------------

                 Key: CAMEL-875
                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 1.4.0
            Reporter: Claus Ibsen
            Priority: Minor
             Fix For: 1.5.0


See nabble:
http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
Gertv suggestion

ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-875:
---------------------------------

    Assignee: Claus Ibsen

> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45375#action_45375 ]

Claus Ibsen commented on CAMEL-875:
-----------------------------------

Committed some code changes. See ExpressionBuilderTest.

> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-875 started by Claus Ibsen.

> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45382#action_45382 ]

Gert Vanthienen commented on CAMEL-875:
---------------------------------------

Claus,

How about wrapping the Scanner in an Iterator and returning that instead of a List from the tokenizer Expressions?  This would allow the splitter to fetch values from the Scanner as it needs them to fill the batches to send instead of first having to create the entire List in memory.  Wdyt?

Gert

> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45383#action_45383 ]

Claus Ibsen commented on CAMEL-875:
-----------------------------------

Gertv

I wanted to keep the same types returned as before = List. And wanted to get some code in place right away, so I could get feedback = and I did, thanks a lot. This is great about all the openness in this community.

But knowing that we have the batch issue as well on the splitter, that would be a really great idea to return an Iterator as you suggest.
However would that break any existing solutions out there?



> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-875) Expression tokenizer should support streams

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-875.
-------------------------------

    Resolution: Fixed

Gertv will continue the work with CAMEL-876

> Expression tokenizer should support streams
> -------------------------------------------
>
>                 Key: CAMEL-875
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-875
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> See nabble:
> http://www.nabble.com/Splitter-for-big-files-td19272583s22882.html
> Gertv suggestion
> ExpressionBuilder and its tokenizeXXX methods should test if the body is Stream, Reader etc. and use java.util.Scanner. Maybe even the String based can use Scanner also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.