[jira] Created: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
camel-ftp - last polltime should be off by default and only used for test scenarious
------------------------------------------------------------------------------------

                 Key: CAMEL-903
                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-ftp
    Affects Versions: 1.4.0
            Reporter: Claus Ibsen
            Assignee: Claus Ibsen
             Fix For: 1.5.0


The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.

As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.

Instead end-users should use a different strategy for "marking files done" such as:
- delete consumed files
- rename consumed files



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-903:
------------------------------

    Priority: Critical  (was: Major)

Its actually a critical bug

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-903 started by Claus Ibsen.

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45703#action_45703 ]

Claus Ibsen commented on CAMEL-903:
-----------------------------------

The last poll timestamp feature is @deprecated. Will be removed in Camel 2.0.

In Camel 1.5 the last poll timestamp will be *disabled* by default. You enabled it with a new option flag.

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-903:
------------------------------

    Description:
The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.

As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.

Instead end-users should use a different strategy for "marking files done" such as:
- delete consumed files
- rename consumed files


See nabble:
http://www.nabble.com/Ftp-consumer-td19489526s22882.html


  was:
The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.

As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.

Instead end-users should use a different strategy for "marking files done" such as:
- delete consumed files
- rename consumed files




> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files
> See nabble:
> http://www.nabble.com/Ftp-consumer-td19489526s22882.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45704#action_45704 ]

Claus Ibsen commented on CAMEL-903:
-----------------------------------

Commited fix.

The flag is named: *consumer.timestamp* its a boolean that is *false* by default. Set it to *true* to enable it as it works in Camel 1.4 or older.

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files
> See nabble:
> http://www.nabble.com/Ftp-consumer-td19489526s22882.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45705#action_45705 ]

Claus Ibsen commented on CAMEL-903:
-----------------------------------

TODO: Need to document it in wiki

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files
> See nabble:
> http://www.nabble.com/Ftp-consumer-td19489526s22882.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-903) camel-ftp - last polltime should be off by default and only used for test scenarious

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-903.
-------------------------------

    Resolution: Fixed

Updated wiki with a warning and added the option.

> camel-ftp - last polltime should be off by default and only used for test scenarious
> ------------------------------------------------------------------------------------
>
>                 Key: CAMEL-903
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-903
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The camel-ftp component uses System.currentTimeMillis stored as last poll time. The remote file timestamp is used for comparing against last poll time if its new and thus a candidate for download.
> As timestamps over FTP is not reliable we should not use this feature by default, but turn it off. It should only be there for test or experimental usage.
> Most FTP servers only sent file timestamp as HH:mm (no seconds). And as a bonus we avoid timezone issues as well.
> Instead end-users should use a different strategy for "marking files done" such as:
> - delete consumed files
> - rename consumed files
> See nabble:
> http://www.nabble.com/Ftp-consumer-td19489526s22882.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.