[jira] Created: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
Maven goal camel:dot should use overridden <mainClass/> when specified
----------------------------------------------------------------------

                 Key: CAMEL-991
                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
             Project: Apache Camel
          Issue Type: Improvement
          Components: tooling
    Affects Versions: 1.4.0
            Reporter: Seb Auvray
             Fix For: 1.5.0, 2.0.0, Future
         Attachments: dot-mainclass-override.patch

Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:

  <build>
    <plugins>
      <!-- Allows the routes to be run via 'mvn camel:run' -->
      <plugin>
        <groupId>org.apache.camel</groupId>
        <artifactId>camel-maven-plugin</artifactId>
        <version>${pom.version}</version>
                <!-- optional, default value: org.apache.camel.spring.Main -->
                <configuration>
                        <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
                </configuration>
      </plugin>
    </plugins>
  </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey reassigned CAMEL-991:
-------------------------------------

    Assignee: Jonathan Anstey

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46505#action_46505 ]

Jonathan Anstey commented on CAMEL-991:
---------------------------------------

Seb, could you re attach your patch and grant the ASF license? We cannot apply any patches that don't have this granted.

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46504#action_46504 ]

Claus Ibsen commented on CAMEL-991:
-----------------------------------

Is useable for some of the other maven goals as well: camel:run etc.

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46506#action_46506 ]

Claus Ibsen commented on CAMEL-991:
-----------------------------------

Seb, could you re attach the patch with the ASF license granted. You should not attach files while creating the tickets as the radiobutton for granting this license is only possible afterwards.

So please use "Attach File" and upload it again with the license.

We can only accept patches with this license

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46507#action_46507 ]

Claus Ibsen commented on CAMEL-991:
-----------------------------------

Jon, remember to document it on the wiki as well

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46508#action_46508 ]

Jonathan Anstey commented on CAMEL-991:
---------------------------------------

Claus, looks like camel:run already had this functionality. Will update the wiki after the patch is applied.

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seb Auvray updated CAMEL-991:
-----------------------------

    Attachment: dot-mainclass-override.patch

Patch With the license

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seb Auvray updated CAMEL-991:
-----------------------------

    Attachment:     (was: dot-mainclass-override.patch)

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46510#action_46510 ]

Seb Auvray commented on CAMEL-991:
----------------------------------

@Claus and Jonathan, Yes camel:run had this overriding possibility but camel:dot would'nt use it.

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46511#action_46511 ]

Jonathan Anstey commented on CAMEL-991:
---------------------------------------

Your patch was applied in revision 705236. Thanks!

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46512#action_46512 ]

Jonathan Anstey commented on CAMEL-991:
---------------------------------------

Updated wiki doc here http://cwiki.apache.org/confluence/display/CAMEL/Camel+Maven+Plugin

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0, 2.0.0, Future
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CAMEL-991) Maven goal camel:dot should use overridden <mainClass/> when specified

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/activemq/browse/CAMEL-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey resolved CAMEL-991.
-----------------------------------

    Fix Version/s:     (was: 2.0.0)
                       (was: Future)
       Resolution: Fixed

> Maven goal camel:dot should use overridden <mainClass/> when specified
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-991
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-991
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: tooling
>    Affects Versions: 1.4.0
>            Reporter: Seb Auvray
>            Assignee: Jonathan Anstey
>             Fix For: 1.5.0
>
>         Attachments: dot-mainclass-override.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Maven goal camel:dot should use overridden <mainClass/> when used as in pom.xml:
>   <build>
>     <plugins>
>       <!-- Allows the routes to be run via 'mvn camel:run' -->
>       <plugin>
>         <groupId>org.apache.camel</groupId>
>         <artifactId>camel-maven-plugin</artifactId>
>         <version>${pom.version}</version>
> <!-- optional, default value: org.apache.camel.spring.Main -->
> <configuration>
> <mainClass>mypackage.boot.camel.CamelStartup</mainClass>
> </configuration>
>       </plugin>
>     </plugins>
>   </build>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.